The !DumpArray sos command emits invalid DML for array elements #13855
Conversation
Element Methodtable is reported correctly but for individual elements, the generated DML uses the MT of the array, not the element, thus giving incorrect results Only value types are affected 0:007> !DumpArray /d 02b16574 Name: WindowsFormsApplication2_SOS_bug.Test[] MethodTable: 011c82ec EEClass: 011c8290 Size: 412(0x19c) bytes Array: Rank 1, Number of elements 100, Type VALUETYPE Element Methodtable: 011c824c [0] 02b1657c => here is the problem
|
LGTM |
|
@janvorli: are contributors also allowed (encouraged?) to initiate builds via dotnet-bot ? |
|
@tvass83 I think you should be able to ask dotnet-bot to rebuild a failed leg. But you should always take a look at the details of the failure before doing that and if there are errors that don't look like infrastructure issues (some Jenkins timeout etc), they should be investigated and if they are not related to the change, GitHub issue should be created before rebuilding. |
|
@dotnet-bot test Tizen armel Cross Debug Build please |
|
@dotnet-bot test Ubuntu16.04 arm Cross Debug Build please |
|
@dotnet-bot test Ubuntu x64 Checked Build and Test please |
|
@dotnet-bot test OSX10.12 x64 Checked Build and Test please |
|
@dotnet-bot test Ubuntu x64 Checked Build and Test please |
|
@dotnet-bot test Ubuntu armlb Cross Release Build please |
|
@dotnet-bot test Ubuntu16.04 armlb Cross Debug Build please |
Element MethodTable is reported correctly but for individual elements, the generated DML uses the MT of the array, not the element, thus giving incorrect results. Only value types are affected.