Throw PlatformNotSupported for named sync primitives on Unix #1387

Merged
merged 1 commit into from Aug 14, 2015

Conversation

Projects
None yet
4 participants
@stephentoub
Member

stephentoub commented Aug 13, 2015

libcoreclr's synchronization primitives implementation currently supports names, but those names have process-wide rather than system-wide scope. This is very dangerous for most code that would want names, as they're typically used for cross-process synchronization, and as such the current behavior could lead to bad race conditions difficult to diagnose. Until a better solution is available, we will throw PlatformNotSupportedException when trying to create such named primitives.

Throw PlatformNotSupported for named sync primitives on Unix
libcoreclr's synchronization primitives implementation currently supports names, but those names have process-wide rather than system-wide scope.  This is very dangerous for most code that would want names, as they're typically used for cross-process synchronization, and as such the current behavior could lead to bad race conditions difficult to diagnose.  Until a better solution is available, we will throw PlatformNotSupportedException when trying to create such named primitives.
@stephentoub

This comment has been minimized.

Show comment
Hide comment
@stephentoub

stephentoub Aug 13, 2015

Member

Corresponding PR in corefx: dotnet/corefx#2796

Member

stephentoub commented Aug 13, 2015

Corresponding PR in corefx: dotnet/corefx#2796

@stephentoub

This comment has been minimized.

Show comment
Hide comment
@jkotas

This comment has been minimized.

Show comment
Hide comment
@jkotas

jkotas Aug 14, 2015

Member

LGTM

Member

jkotas commented Aug 14, 2015

LGTM

jkotas added a commit that referenced this pull request Aug 14, 2015

Merge pull request #1387 from stephentoub/named_primitives
Throw PlatformNotSupported for named sync primitives on Unix

@jkotas jkotas merged commit ed73a1c into dotnet:master Aug 14, 2015

1 check passed

default Build finished. No test results found.
Details

@stephentoub stephentoub deleted the stephentoub:named_primitives branch Aug 14, 2015

stephentoub added a commit to stephentoub/corefx that referenced this pull request Aug 14, 2015

Re-enable several System.Threading tests
With dotnet/coreclr#1387 merged, these can now be enabled.

@stephentoub stephentoub referenced this pull request in dotnet/corefx Aug 14, 2015

Merged

Re-enable several System.Threading tests #2815

stephentoub added a commit to stephentoub/corefx that referenced this pull request Aug 15, 2015

Re-enable several System.Threading tests
With dotnet/coreclr#1387 merged, these can now be enabled.

rajansingh10 added a commit to rajansingh10/corefx that referenced this pull request Aug 20, 2015

rajansingh10 added a commit to rajansingh10/corefx that referenced this pull request Aug 20, 2015

rajansingh10 added a commit to rajansingh10/corefx that referenced this pull request Oct 16, 2015

rajansingh10 added a commit to rajansingh10/corefx that referenced this pull request Oct 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment