This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[x86/Linux] Use VI tag instead of VV #14215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parjong
changed the title
|
@dotnet-bot test Ubuntu x64 Formatting please |
|
Thanks! Where was the test that failed for this? Wondering why the original PR didn't catch it... The list of FCALL "gotchas" could probably be updated to indicate pointers (which are variable size) should be treated as |
|
I will only show up on Linux x86. |
|
Ah, alright. |
|
FYI, I found this issue while running FX Innerloop tests (System.Linq.Parallel.Tests, System.Runtime.Extensions.Tests, System.Runtime.Numerics.Tests). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMSingle::ModF/COMDouble::ModF passes a pointer (which should be treated as a integer value) as 2nd argument, but are declared with _VV tag.