This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
fix for il to native mapping etw events #15038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
jkotas
reviewed
Nov 15, 2017
src/debug/ee/debugger.cpp
Outdated
| @@ -3133,7 +3133,7 @@ HRESULT Debugger::GetILToNativeMapping(UINT_PTR pNativeCodeStartAddress, ULONG32 | |||
| // | |||
|
|
|||
| HRESULT Debugger::GetILToNativeMappingIntoArrays( | |||
| MethodDesc * pMD, | |||
| UINT_PTR pCode, | |||
jkotas
reviewed
Nov 15, 2017
src/debug/ee/debugger.cpp
Outdated
| @@ -3157,7 +3157,7 @@ HRESULT Debugger::GetILToNativeMappingIntoArrays( | |||
|
|
|||
| // Get the JIT info by functionId. | |||
|
|
|||
| DebuggerJitInfo * pDJI = GetLatestJitInfoFromMethodDesc(pMD); | |||
| DebuggerJitInfo * pDJI = GetJitInfoFromAddr(pCode); | |||
There was a problem hiding this comment.
Converting code address back to MethodDesc is not cheap operation. It would be better to use GetJitInfo overload that takes both code address and MethodDesc to avoid this lookup.
jkotas
approved these changes
Nov 15, 2017
|
I am investigating the test failures and will merge when I understand or fix the arm and mac failures, they seem to be deterministic and I want to understand more. I was sidetracked by other work items but will hopefully have it by tomorrow. |
|
@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test |
|
@dotnet-bot test Ubuntu armlb Cross Debug Innerloop Build |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #14947, previously the il to native mapping ETW events would always emit events for the same native code version, this change fixes that.