This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Updating the build script to work when python is installed to a path containing a space. #15707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…containing a space.
nategraf
approved these changes
Jan 3, 2018
BruceForstall
approved these changes
Jan 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI. @nategraf, @jkotas, @brianrob, @BruceForstall
#15611, which was merged yesterday, introduced a new Python dependency in build.cmd. The delayed expansion does not work when Python is installed to a path containing a space and you will wind up with a failure similar to:
C:\Program: can't open file 'Files\Python36\python.exe': [Errno 2] No such file or directoryThis resolves the issue by ensuring the expanded variable is surrounded with quotes.