This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Add Unsafe.IsAddressGreaterThan / IsAddressLessThan #15988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
approved these changes
Jan 24, 2018
| /// </remarks> | ||
| [Intrinsic] | ||
| [NonVersionable] | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] |
There was a problem hiding this comment.
Is Aggressive inlining necessary or just there for good measure?
There was a problem hiding this comment.
It's the same pattern used by the other methods on the type - I assume for good measure?
dotnet-bot
pushed a commit
to dotnet/corert
that referenced
this pull request
Jan 24, 2018
…5988) Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
dotnet-bot
pushed a commit
to dotnet/corefx
that referenced
this pull request
Jan 24, 2018
…5988) Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
jkotas
pushed a commit
to dotnet/corefx
that referenced
this pull request
Jan 24, 2018
…5988) Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Jan 24, 2018
…5988) Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one half of a two-part change. The corefx PR which includes devdoc and unit tests is at (dotnet/corefx#26554).
See https://github.com/dotnet/corefx/issues/26451 for more details.
/cc @jkotas @stephentoub @ahsonkhan