This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Don't check for libintl.h on Darwin (OSX) #20094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test |
|
@dotnet-bot test Windows_NT x64 Release CoreFX Tests @dotnet-bot test Windows_NT x64 Formatting |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build fails to link if
HAVE_LIBINTL_His set when building on a Mac.libintlis unexpected on OSX and isn't configured correctly. This change makes OSX builds always ignorelibintl. The intent is to use native internationalization anyway, so not using this library is correct.Addresses https://github.com/dotnet/coreclr/issues/20092, but this change is also needed in
release/2.1andrelease/2.2to avoid adding patches in source-build.