This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix memory reporting for GC in crash dumps #20233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EnumSvrGlobalMemoryRegions
|
@dotnet-bot test Ubuntu arm Cross Checked Innerloop Build and Test |
|
@Maoni0 can you take a look? |
|
Thanks! |
mikem8361
added a commit
to mikem8361/coreclr
that referenced
this pull request
Jan 4, 2019
GC heap globals like ephemeral_heap_segment and finalize_queue are null/invalid for a server GC. Add a check to skip the workstation GC memory enumeration if server. The server memory enumeration already skips if workstation GC. The dynamic module fix is still needed, createdump would have still hit this problem after the GC heap fix. Report the entire generation table in EnumWksGlobalMemoryRegions and EnumSvrGlobalMemoryRegions (dotnet#20233).
RussKeldorph
pushed a commit
that referenced
this pull request
Jan 10, 2019
GC heap globals like ephemeral_heap_segment and finalize_queue are null/invalid for a server GC. Add a check to skip the workstation GC memory enumeration if server. The server memory enumeration already skips if workstation GC. The dynamic module fix is still needed, createdump would have still hit this problem after the GC heap fix. Report the entire generation table in EnumWksGlobalMemoryRegions and EnumSvrGlobalMemoryRegions (#20233).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now part of the generation table is not being reported when a crash dump is collected. It doesn't matter if a full memory dump is collected since the memory is present anyways, but it causes an error when using SOS commands on heap/mini dumps.
max_gen is zero indexed, so
max_gen + 1is the number of heaps, and then one more is necessary to account for the large object heap, so we end up withmax_gen + 2.