-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Use Xunit v2.4.1 (prerelease) #20506
Use Xunit v2.4.1 (prerelease) #20506
Conversation
I recommend to use the same version as we do in corefx (2.4.1 prerelease): https://github.com/dotnet/corefx/blob/master/dependencies.props#L51 |
@ViktorHofer I will update the version to match corefx, thanks. |
No Try to run them again |
@dotnet-bot test Ubuntu16.04 arm64 Cross Checked Innerloop Build and Test |
Build job failed @dotnet-bot test Ubuntu16.04 arm64 Cross Checked no_tiered_compilation_innerloop Build and Test |
I believe some arm legs are busted. |
@ViktorHofer Thanks again for fixing conflicts! Indeed seems that updating to this version fixes #20392 |
@dotnet-bot test Ubuntu16.04 arm64 Cross Checked Innerloop Build and Test |
@dotnet-bot test Windows_NT arm Cross Checked Innerloop Build and Test |
Hmm Jobs didn't restart Try again... @dotnet-bot test Ubuntu16.04 arm64 Cross Checked Innerloop Build and Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if tests pass.
I hope it fixes the problems!
…#20506) From https://xunit.github.io/releases/2.4.1-pre-4059 **xUnit.net 2.4.1 Pre-Release (build 4059)** Core framework * BUG: Fixed an issue with xunit.abstractions not correctly installing with older versions of Visual Studio (pre-2017). * BUG: Fixed an issue with ByRef types with .NET Core 2.1. * BUG: Removed an unnecessary first chance exception related to attempting to load configuration files. * BUG: Fixed an issue where synchronous and asynchronous disposal of test classes were running in parallel. The documented behavior is that asynchronous disposal (via IAsyncLifetime) runs to completion before synchronous disposal (via IDisposable). Console runner * BUG: Fixed an issue with XML element order with the NUnit report. MSBuild runner * BUG: Fixed an issue with XML element order with the NUnit report.
…/coreclr#20506) From https://xunit.github.io/releases/2.4.1-pre-4059 **xUnit.net 2.4.1 Pre-Release (build 4059)** Core framework * BUG: Fixed an issue with xunit.abstractions not correctly installing with older versions of Visual Studio (pre-2017). * BUG: Fixed an issue with ByRef types with .NET Core 2.1. * BUG: Removed an unnecessary first chance exception related to attempting to load configuration files. * BUG: Fixed an issue where synchronous and asynchronous disposal of test classes were running in parallel. The documented behavior is that asynchronous disposal (via IAsyncLifetime) runs to completion before synchronous disposal (via IDisposable). Console runner * BUG: Fixed an issue with XML element order with the NUnit report. MSBuild runner * BUG: Fixed an issue with XML element order with the NUnit report. Commit migrated from dotnet/coreclr@f53df5b
Update to Xunit v2.4.1-pre.build.4059 to try fixing https://github.com/dotnet/coreclr/issues/20392
From https://xunit.github.io/releases/2.4.1-pre-4059