Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Use Xunit v2.4.1 (prerelease) #20506

Merged
merged 3 commits into from
Oct 23, 2018
Merged

Use Xunit v2.4.1 (prerelease) #20506

merged 3 commits into from
Oct 23, 2018

Conversation

echesakov
Copy link

@echesakov echesakov commented Oct 20, 2018

Update to Xunit v2.4.1-pre.build.4059 to try fixing https://github.com/dotnet/coreclr/issues/20392

From https://xunit.github.io/releases/2.4.1-pre-4059

xUnit.net 2.4.1 Pre-Release (build 4059)

Core framework

  • BUG: Fixed an issue with xunit.abstractions not correctly installing with older versions of Visual Studio (pre-2017).
  • BUG: Fixed an issue with ByRef types with .NET Core 2.1.
  • BUG: Removed an unnecessary first chance exception related to attempting to load configuration files.
  • BUG: Fixed an issue where synchronous and asynchronous disposal of test classes were running in parallel. The documented behavior is that asynchronous disposal (via IAsyncLifetime) runs to completion before synchronous disposal (via IDisposable).

Console runner

  • BUG: Fixed an issue with XML element order with the NUnit report.
    MSBuild runner
  • BUG: Fixed an issue with XML element order with the NUnit report.

@echesakov echesakov added area-Infrastructure-coreclr * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) labels Oct 20, 2018
@ViktorHofer
Copy link
Member

I recommend to use the same version as we do in corefx (2.4.1 prerelease): https://github.com/dotnet/corefx/blob/master/dependencies.props#L51

@echesakov
Copy link
Author

@ViktorHofer I will update the version to match corefx, thanks.

@echesakov echesakov removed the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Oct 23, 2018
@echesakov echesakov changed the title [NO MERGE] Use stable release of Xunit v2.4.0 in dependencies.props Use Xunit v2.4.1 (prerelease) in dependencies.props Oct 23, 2018
@echesakov echesakov changed the title Use Xunit v2.4.1 (prerelease) in dependencies.props Use Xunit v2.4.1 (prerelease) Oct 23, 2018
@echesakov
Copy link
Author

No System.IO.FileLoadException in the following tst jobs:
https://ci.dot.net/job/dotnet_coreclr/job/master/job/arm_cross_checked_ubuntu_innerloop_tst_prtest/4969
https://ci.dot.net/job/dotnet_coreclr/job/master/job/jitstress/job/arm_cross_checked_ubuntu_no_tiered_compilation_innerloop_tst_prtest/2163
https://ci.dot.net/job/dotnet_coreclr/job/master/job/arm64_cross_checked_ubuntu16.04_innerloop_tst_prtest/480
https://ci.dot.net/job/dotnet_coreclr/job/master/job/jitstress/job/arm64_cross_checked_ubuntu16.04_no_tiered_compilation_innerloop_tst_prtest/481

Try to run them again
@dotnet-bot test Ubuntu16.04 arm64 Cross Checked Innerloop Build and Test
@dotnet-bot test Ubuntu16.04 arm64 Cross Checked no_tiered_compilation_innerloop Build and Test
@dotnet-bot test Ubuntu arm Cross Checked Innerloop Build and Test
@dotnet-bot test Ubuntu arm Cross Checked no_tiered_compilation_innerloop Build and Test

@echesakov
Copy link
Author

@dotnet-bot test Ubuntu16.04 arm64 Cross Checked Innerloop Build and Test
@dotnet-bot test Ubuntu16.04 arm64 Cross Checked no_tiered_compilation_innerloop Build and Test
@dotnet-bot test Ubuntu arm Cross Checked Innerloop Build and Test
@dotnet-bot test Ubuntu arm Cross Checked no_tiered_compilation_innerloop Build and Test

@echesakov
Copy link
Author

Build job failed

@dotnet-bot test Ubuntu16.04 arm64 Cross Checked no_tiered_compilation_innerloop Build and Test

@ViktorHofer
Copy link
Member

I believe some arm legs are busted.

@echesakov
Copy link
Author

@ViktorHofer Thanks again for fixing conflicts!

Indeed seems that updating to this version fixes #20392

@echesakov
Copy link
Author

@dotnet-bot test Ubuntu16.04 arm64 Cross Checked Innerloop Build and Test
@dotnet-bot test Ubuntu16.04 arm64 Cross Checked no_tiered_compilation_innerloop Build and Test

@echesakov
Copy link
Author

@dotnet-bot test Windows_NT arm Cross Checked Innerloop Build and Test

@echesakov
Copy link
Author

Hmm Jobs didn't restart Try again...

@dotnet-bot test Ubuntu16.04 arm64 Cross Checked Innerloop Build and Test
@dotnet-bot test Ubuntu16.04 arm64 Cross Checked no_tiered_compilation_innerloop Build and Test

Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass.

I hope it fixes the problems!

@echesakov echesakov merged commit f53df5b into dotnet:master Oct 23, 2018
A-And pushed a commit to A-And/coreclr that referenced this pull request Nov 20, 2018
…#20506)

From https://xunit.github.io/releases/2.4.1-pre-4059

**xUnit.net 2.4.1 Pre-Release (build 4059)**

Core framework 
* BUG: Fixed an issue with xunit.abstractions not correctly installing with older versions of Visual Studio (pre-2017). 
* BUG: Fixed an issue with ByRef types with .NET Core 2.1. 
* BUG: Removed an unnecessary first chance exception related to attempting to load configuration files. 
* BUG: Fixed an issue where synchronous and asynchronous disposal of test classes were running in parallel. The documented behavior is that asynchronous disposal (via IAsyncLifetime) runs to completion before synchronous disposal (via IDisposable).

Console runner 
* BUG: Fixed an issue with XML element order with the NUnit report.

MSBuild runner 
* BUG: Fixed an issue with XML element order with the NUnit report.
@echesakov echesakov deleted the UseStableXunitPackageVersion2.4.0 branch April 8, 2019 18:48
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
…/coreclr#20506)

From https://xunit.github.io/releases/2.4.1-pre-4059

**xUnit.net 2.4.1 Pre-Release (build 4059)**

Core framework 
* BUG: Fixed an issue with xunit.abstractions not correctly installing with older versions of Visual Studio (pre-2017). 
* BUG: Fixed an issue with ByRef types with .NET Core 2.1. 
* BUG: Removed an unnecessary first chance exception related to attempting to load configuration files. 
* BUG: Fixed an issue where synchronous and asynchronous disposal of test classes were running in parallel. The documented behavior is that asynchronous disposal (via IAsyncLifetime) runs to completion before synchronous disposal (via IDisposable).

Console runner 
* BUG: Fixed an issue with XML element order with the NUnit report.

MSBuild runner 
* BUG: Fixed an issue with XML element order with the NUnit report.

Commit migrated from dotnet/coreclr@f53df5b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants