Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Corrected Typos and grammar #20658

Merged
merged 3 commits into from Oct 30, 2018
Merged

Corrected Typos and grammar #20658

merged 3 commits into from Oct 30, 2018

Conversation

ShreyasJejurkar
Copy link

Corrected some spelling typos and grammar as per English language guidelines

@dnfclas
Copy link

dnfclas commented Oct 28, 2018

CLA assistant check
All CLA requirements met.

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, but a bunch of these changes should be reverted.

Documentation/building/cross-building.md Outdated Show resolved Hide resolved
Documentation/building/android.md Outdated Show resolved Hide resolved
Documentation/building/cross-building.md Outdated Show resolved Hide resolved
Documentation/building/cross-building.md Outdated Show resolved Hide resolved
Documentation/building/crossgen.md Outdated Show resolved Hide resolved
Documentation/building/testing-with-corefx.md Outdated Show resolved Hide resolved
Documentation/building/windows-instructions.md Outdated Show resolved Hide resolved
Documentation/building/windows-instructions.md Outdated Show resolved Hide resolved
Documentation/building/windows-test-instructions.md Outdated Show resolved Hide resolved
Documentation/building/windows-test-instructions.md Outdated Show resolved Hide resolved
@ShreyasJejurkar
Copy link
Author

Ok. I did whatever changes you pointed out, some of those were not looking good for me. But still, I corrected them as per your suggestions.

@stephentoub
Copy link
Member

I did whatever changes you pointed out

Thanks... I see you marked a bunch of my comments as resolved, but I don't see an updated commit. Did you push it?

@ShreyasJejurkar
Copy link
Author

I did whatever changes you pointed out

Thanks... I see you marked a bunch of my comments as resolved, but I don't see an updated commit. Did you push it?

I did now. Please have a look at it.

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two remaining comments to be addressed, otherwise LGTM.

@stephentoub stephentoub merged commit 9d92078 into dotnet:master Oct 30, 2018
kouvel pushed a commit to kouvel/coreclr that referenced this pull request Nov 3, 2018
* Corrected some typos and grammar as per English language guidelines.

* Reverted some of the changes

* Reverted back some changes Phase 2
A-And pushed a commit to A-And/coreclr that referenced this pull request Nov 20, 2018
* Corrected some typos and grammar as per English language guidelines.

* Reverted some of the changes

* Reverted back some changes Phase 2
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
* Corrected some typos and grammar as per English language guidelines.

* Reverted some of the changes

* Reverted back some changes Phase 2


Commit migrated from dotnet/coreclr@9d92078
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants