This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Change System.Object to ClassInterface.None #21137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
force-pushed
the
ClassInterface
branch
from
d2749f1
to
6432bbd
Compare
|
This will make the QI for the desktop interfaces that are not implemented in CoreCLR to fail right away without throwing exceptions. |
Prevents .NET Framework legacy interfaces from leaking out. Fixes https://github.com/dotnet/corefx/issues/33638
jkotas
force-pushed
the
ClassInterface
branch
from
6432bbd
to
56342dc
Compare
stephentoub
approved these changes
Nov 21, 2018
AaronRobinsonMSFT
approved these changes
Nov 21, 2018
|
This should avoid the FCE by failing earlier in the native side. This will mean that the tracing of errors from Uia will be missing the provider info. You may want to reach out to the owning Windows team to let them know that they might want to update their error tracing to preserve this (for example, by adding their own interface method to return the type name as a string). |
ericstj
approved these changes
Nov 21, 2018
|
Opened issue against wpf. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Change System.Object to ClassInterface.None Prevents .NET Framework legacy interfaces from leaking out. Fixes https://github.com/dotnet/corefx/issues/33638 * Use AutoDispatch for System.Object Commit migrated from dotnet/coreclr@2079632
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents .NET Framework legacy interfaces from leaking out.
Fixes https://github.com/dotnet/corefx/issues/33638