This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix some SOS commands after SharedDomain removal #21401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
approved these changes
Dec 6, 2018
|
Yes, any change to SOS now should work on older runtime versions. Otherwise, I can't port it to the new SOS in the diagnostics repo. |
|
I was also considering that, but I was thinking that we've never had multiple domains, so this should work for any older version of coreclr. @mikem8361 is the diagnostics repo meant for desktop too? |
|
Not we currently don’t and will not support the desktop runtime in the diagnostics repo.
|
The recent removal of SharedDomain has broken some SOS commands, like Name2EE or bpmd. There was a code that was enumerating domains and obtaining some information on them. And the shared domain pointer from DacpAppDomainStoreData was being included in the list of domains. As it is NULL now, we have failed to get the information and the domain iteration loop was exited prematurely. I have made SOS resilient to the possibility of missing shared domain. On older runtimes, the shared domain is still being reported.
janvorli
force-pushed
the
fix-sos-shareddomain
branch
from
6125654
to
0f5d816
Compare
|
@jkotas, @mikem8361 I've replaced the change with one that keeps support for showing / enumerating shared domain on older runtimes where it is present and only ignore it on runtimes that have the shared domain removed. |
|
@dotnet-bot test Windows_NT arm Cross Checked Innerloop Build and Test |
mikem8361
approved these changes
Dec 7, 2018
morganbr
pushed a commit
that referenced
this pull request
Dec 14, 2018
The recent removal of SharedDomain has broken some SOS commands, like Name2EE or bpmd. There was a code that was enumerating domains and obtaining some information on them. And the shared domain pointer from DacpAppDomainStoreData was being included in the list of domains. As it is NULL now, we have failed to get the information and the domain iteration loop was exited prematurely. I have made SOS resilient to the possibility of missing shared domain. On older runtimes, the shared domain is still being reported.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
The recent removal of SharedDomain has broken some SOS commands, like Name2EE or bpmd. There was a code that was enumerating domains and obtaining some information on them. And the shared domain pointer from DacpAppDomainStoreData was being included in the list of domains. As it is NULL now, we have failed to get the information and the domain iteration loop was exited prematurely. I have made SOS resilient to the possibility of missing shared domain. On older runtimes, the shared domain is still being reported. Commit migrated from dotnet/coreclr@af46c51
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent removal of SharedDomain has broken some SOS commands, like
Name2EE, EEHeap or bpmd. There was a code that was enumerating domains and
obtaining some information on them. And the shared domain pointer from
DacpAppDomainStoreData was being included in the list of domains. As it
is NULL now, we have failed to get the information and the domain
iteration loop was exited prematurely.
I have removed all references to the shared domain from SOS to fix that.