This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fixes issue #21485 and #21484 #21526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #21485: fix EnumProcessModules hPseudoCurrentProcess bug. Added handle reference. Issue #21484: createdump segfaults with ASP.NET app The problem is the ClrDataModule Request faulted on a dynamic module getting the file layout flag. Fixed the Request code not get the file layout and in the crash dump code skip any dynamic modules.
jkotas
reviewed
Dec 13, 2018
| // Can not get the file layout for a dynamic module | ||
| if (!outGMD->IsDynamic) | ||
| { | ||
| outGMD->IsFileLayout = pPEFile->GetLoaded()->IsFlat(); |
There was a problem hiding this comment.
Initialize to something valid on the else path so that it is not garbage?
jkotas
reviewed
Dec 13, 2018
| @@ -708,6 +708,17 @@ CrashInfo::EnumerateManagedModules(IXCLRDataProcess* pClrDataProcess) | |||
| break; | |||
| } | |||
|
|
|||
| // Skip any dynamic modules. The Request call below on some DACs crashes on dynamic modules. | |||
There was a problem hiding this comment.
Do we understand the impact of skipping the dynamic modules? Are there other things that will start failing downstream when we have no data for dynamic modules?
|
The whole DacpGetModuleData struct is zero’ed at the beginning of this function so the value will be FALSE if dynamic.
|
|
Skipping dynamic modules here shouldn’t have any impact because ReplaceModuleMapping usually updates the module name for an existing region. Dynamic modules don’t have a name or a load address so they would be skipped in the below checks.
This assumes that the memory for a dynamic module has already been added/enum’ed as part of one of the heaps. Since DacpGetModuleData.Request doesn’t return the load address or size, I’m not sure how to make sure it is included in the dump.
|
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…eclr#21526) Issue dotnet/coreclr#21485: fix EnumProcessModules hPseudoCurrentProcess bug. Added handle reference. Issue dotnet/coreclr#21484: createdump segfaults with ASP.NET app The problem is the ClrDataModule Request faulted on a dynamic module getting the file layout flag. Fixed the Request code not get the file layout and in the crash dump code skip any dynamic modules. Commit migrated from dotnet/coreclr@a6403ba
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #21485: fix EnumProcessModules hPseudoCurrentProcess bug.
Added handle reference.
Issue #21484: createdump segfaults with ASP.NET app
The problem is the ClrDataModule Request faulted on a dynamic module
getting the file layout flag.
Fixed the Request code not get the file layout and in the crash dump
code skip any dynamic modules.