Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Fix failures caused by ICU regression #24190

Merged
merged 1 commit into from
Apr 23, 2019

Commits on Apr 23, 2019

  1. Fix failures caused by ICU regression

    Fixes https://github.com/dotnet/corefx/issues/37098
    
    .NET Core depends on ICU when running on Linux/OSX. Recently some people raised some failure on the framework stack. After investigation we found a regression in ICU which is the root cause of this failure. The regression is, when calling ICU to get some date patterns/properties, in some cases ICU return error code U_MISSING_RESOURCE_ERROR. Although the framework code written to fallback to some invariant values at that time, but we had some wrong line of code which assumed we never fail and trying to access the returned value without checking. That cause the framework to throw NullReferenceException.
    
    The fix here is to make the framework resilient against such cases and continue to run nicely. I have contact ICU support members and I learned there is similar issue tracked in ICU repo https://unicode-org.atlassian.net/browse/ICU-20558
    tarekgh committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    13db3d4 View commit details
    Browse the repository at this point in the history