Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Improve Precision to 10 microseconds in timespan #24279

Merged
merged 4 commits into from Apr 29, 2019
Merged

Improve Precision to 10 microseconds in timespan #24279

merged 4 commits into from Apr 29, 2019

Conversation

Anipik
Copy link

@Anipik Anipik commented Apr 26, 2019

Fixes https://github.com/dotnet/corefx/issues/32430
Related corefx PR dotnet/corefx#37235

double millis = tmp + (value >= 0 ? 0.5 : -0.5);

This line was added because casting double to long was dropping the decimal part and we expect it to rounded off. This wont be the case anymore.

@Anipik Anipik requested a review from danmoseley April 26, 2019 22:51
@Anipik Anipik mentioned this pull request Apr 26, 2019
Closed
@Anipik
Copy link
Author

Anipik commented Apr 26, 2019

@danmosemsft should i disable the failing tests in corefx ? These failing tests need to changed to increase the precision.
I am already doing that in linked corefx PR

@jkotas
Copy link
Member

jkotas commented Apr 26, 2019

Disable the failing CoreFX tests in https://github.com/dotnet/coreclr/blob/master/tests/CoreFX/CoreFX.issues.json

@danmoseley
Copy link
Member

error in test json

17:34:44 Unhandled Exception: System.ArgumentException: An item with the same key has already been added. Key: System.Runtime.Tests
17:34:44    at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
17:34:44    at CoreFX.TestUtils.TestFileSetup.Helpers.TestFileHelper.DeserializeTestJson(String testDefinitionFilePath) in /mnt/j/workspace/dotnet_coreclr/master/x64_checked_ubuntu_corefx_innerloop_prtest/tests/src/Common/CoreFX/TestFileSetup/Helpers/TestFileHelper.cs:line 121

@danmoseley
Copy link
Member

Fixed JSON. As much as I don't like XML either, element ordering is significant, which might incite people to put things in alphabetical order...

@danmoseley
Copy link
Member

Seems unrelated CI issues

@Anipik
Copy link
Author

Anipik commented Apr 29, 2019

@dotnet-bot test Windows_NT x64 Checked CoreFX Tests
@dotnet-bot test Windows_NT x64 Release CoreFX Tests
@dotnet-bot test Windows_NT x64 Formatting

@Anipik Anipik merged commit 6bca031 into dotnet:master Apr 29, 2019
@Anipik Anipik deleted the improvePrecision branch April 29, 2019 20:56
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/mono that referenced this pull request Apr 29, 2019
@Anipik @dotnet-bot
Improve Precision to 10 microseconds in timespan (dotnet/coreclr#24279)
db218b4 
* Increasing precision properly and leaving the rounding of to casting operator

* disabling corefx tests in coreclr and addressing feedback

* correcting test project name

* Fix json

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corert that referenced this pull request Apr 29, 2019
@Anipik @dotnet-bot
Improve Precision to 10 microseconds in timespan (dotnet/coreclr#24279)
eb5d19c 
* Increasing precision properly and leaving the rounding of to casting operator

* disabling corefx tests in coreclr and addressing feedback

* correcting test project name

* Fix json

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corefx that referenced this pull request Apr 29, 2019
@Anipik @dotnet-bot
Improve Precision to 10 microseconds in timespan (dotnet/coreclr#24279)
09d1c3d 
* Increasing precision properly and leaving the rounding of to casting operator

* disabling corefx tests in coreclr and addressing feedback

* correcting test project name

* Fix json

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
stephentoub pushed a commit to dotnet/corefx that referenced this pull request Apr 29, 2019
@Anipik @stephentoub
Improve Precision to 10 microseconds in timespan (dotnet/coreclr#24279)
2b08890 
* Increasing precision properly and leaving the rounding of to casting operator

* disabling corefx tests in coreclr and addressing feedback

* correcting test project name

* Fix json

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas pushed a commit to dotnet/corert that referenced this pull request Apr 30, 2019
@Anipik @jkotas
Improve Precision to 10 microseconds in timespan (dotnet/coreclr#24279)
2c140f8 
* Increasing precision properly and leaving the rounding of to casting operator

* disabling corefx tests in coreclr and addressing feedback

* correcting test project name

* Fix json

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
marek-safar pushed a commit to mono/mono that referenced this pull request Apr 30, 2019
@Anipik @marek-safar
Improve Precision to 10 microseconds in timespan (dotnet/coreclr#24279)
b3eeab7 
* Increasing precision properly and leaving the rounding of to casting operator

* disabling corefx tests in coreclr and addressing feedback

* correcting test project name

* Fix json

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
@tannergooding tannergooding mentioned this pull request Apr 30, 2019
Merged
@KrzysFR KrzysFR mentioned this pull request Jan 31, 2020
Open
@idlerboris idlerboris mentioned this pull request Feb 1, 2020
Closed
@tdykstra tdykstra mentioned this pull request Jun 16, 2021
Closed
@wzchua wzchua mentioned this pull request Oct 8, 2021
Open
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@Anipik
Improve Precision to 10 microseconds in timespan (dotnet/coreclr#24279)
2503500 
* Increasing precision properly and leaving the rounding of to casting operator

* disabling corefx tests in coreclr and addressing feedback

* correcting test project name

* Fix json


Commit migrated from dotnet/coreclr@6bca031
@fanruinet fanruinet mentioned this pull request Nov 15, 2022
Open
henricj added a commit to henricj/FixVox that referenced this pull request Dec 2, 2022
@henricj
The .NET Core TimeSpan.FromSeconds() no longer truncates.
afa07a6 
dotnet/coreclr#24279
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@juliusfriedman juliusfriedman juliusfriedman approved these changes

@danmoseley danmoseley Awaiting requested review from danmoseley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Anipik @jkotas @danmoseley @juliusfriedman