Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove concept of AppDomains from the GC #24536

Merged
merged 3 commits into from May 16, 2019

Conversation

Projects
None yet
2 participants
@davidwrighton
Copy link
Member

commented May 11, 2019

  • Leave constructs allowing for multiple handle tables, as scenarios for that have been proposed
Remove concept of AppDomains from the GC
- Leave constructs allowing for multiple handle tables, as scenarios for that have been proposed
@Maoni0

This comment has been minimized.

Copy link
Member

commented May 14, 2019

do you wanna just remove all the code related to FEATURE_APPDOMAIN_RESOURCE_MONITORING and delete that define altogether? I see there's still something related in GCHeap::Promote.

@davidwrighton

This comment has been minimized.

Copy link
Member Author

commented May 14, 2019

I can do that. The code that I removed as part of this change around FEATURE_APPDOMAIN_RESOURCE_MONITORING was strictly parts of it that are actually appdomain tied, but I can easily just remove it all

@davidwrighton davidwrighton changed the title [WIP] Remove concept of AppDomains from the GC Remove concept of AppDomains from the GC May 15, 2019

@davidwrighton davidwrighton marked this pull request as ready for review May 15, 2019

@davidwrighton davidwrighton merged commit bdb9959 into dotnet:master May 16, 2019

37 checks passed

WIP Ready for review
Details
coreclr-ci Build #20190515.724 succeeded
Details
coreclr-ci (Build Linux arm checked) Build Linux arm checked succeeded
Details
coreclr-ci (Build Linux arm64 checked) Build Linux arm64 checked succeeded
Details
coreclr-ci (Build Linux arm64 release) Build Linux arm64 release succeeded
Details
coreclr-ci (Build Linux_musl x64 checked) Build Linux_musl x64 checked succeeded
Details
coreclr-ci (Build Linux_musl x64 release) Build Linux_musl x64 release succeeded
Details
coreclr-ci (Build Linux_rhel6 x64 release) Build Linux_rhel6 x64 release succeeded
Details
coreclr-ci (Build Windows_NT arm Checked) Build Windows_NT arm Checked succeeded
Details
coreclr-ci (Build Windows_NT arm64 Checked) Build Windows_NT arm64 Checked succeeded
Details
coreclr-ci (Build Windows_NT x64 Checked) Build Windows_NT x64 Checked succeeded
Details
coreclr-ci (Build Windows_NT x64 Debug) Build Windows_NT x64 Debug succeeded
Details
coreclr-ci (Build Windows_NT x86 Checked) Build Windows_NT x86 Checked succeeded
Details
coreclr-ci (Build Windows_NT x86 Debug) Build Windows_NT x86 Debug succeeded
Details
coreclr-ci (Formatting Linux x64) Formatting Linux x64 succeeded
Details
coreclr-ci (Formatting Windows_NT x64) Formatting Windows_NT x64 succeeded
Details
coreclr-ci (Test Pri0 Linux arm64_checked) Test Pri0 Linux arm64_checked succeeded
Details
coreclr-ci (Test Pri0 Linux arm_checked) Test Pri0 Linux arm_checked succeeded
Details
coreclr-ci (Test Pri0 Linux x64_checked) Test Pri0 Linux x64_checked succeeded
Details
coreclr-ci (Test Pri0 Linux_musl x64_checked) Test Pri0 Linux_musl x64_checked succeeded
Details
coreclr-ci (Test Pri0 Linux_musl x64_release) Test Pri0 Linux_musl x64_release succeeded
Details
coreclr-ci (Test Pri0 OSX x64_checked) Test Pri0 OSX x64_checked succeeded
Details
coreclr-ci (Test Pri0 Windows_NT arm64_checked) Test Pri0 Windows_NT arm64_checked succeeded
Details
coreclr-ci (Test Pri0 Windows_NT arm_checked) Test Pri0 Windows_NT arm_checked succeeded
Details
coreclr-ci (Test Pri0 Windows_NT x64_checked) Test Pri0 Windows_NT x64_checked succeeded
Details
coreclr-ci (Test Pri0 Windows_NT x86_checked) Test Pri0 Windows_NT x86_checked succeeded
Details
coreclr-ci (Test Pri0 CoreFX Windows_NT x64_release) Test Pri0 CoreFX Windows_NT x64_release succeeded
Details
coreclr-ci (Test Pri0 R2R Linux x64_checked) Test Pri0 R2R Linux x64_checked succeeded
Details
coreclr-ci (Test Pri0 R2R OSX x64_checked) Test Pri0 R2R OSX x64_checked succeeded
Details
coreclr-ci (Test Pri0 R2R Windows_NT x64_checked) Test Pri0 R2R Windows_NT x64_checked succeeded
Details
coreclr-ci (Test Pri0 R2R Windows_NT x86_checked) Test Pri0 R2R Windows_NT x86_checked succeeded
Details
coreclr-ci (build Linux x64 Checked) build Linux x64 Checked succeeded
Details
coreclr-ci (build OSX x64 Checked) build OSX x64 Checked succeeded
Details
coreclr-ci (build Windows_NT arm Release) build Windows_NT arm Release succeeded
Details
coreclr-ci (build Windows_NT arm64 Release) build Windows_NT arm64 Release succeeded
Details
coreclr-ci (build Windows_NT x64 Release) build Windows_NT x64 Release succeeded
Details
license/cla All CLA requirements met.
Details

franksinankaya added a commit to franksinankaya/coreclr that referenced this pull request May 30, 2019

Remove concept of AppDomains from the GC (dotnet#24536)
* Remove concept of AppDomains from the GC
- Leave constructs allowing for multiple handle tables, as scenarios for that have been proposed
- Remove FEATURE_APPDOMAIN_RESOURCE_MONITORING
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.