Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

PInvoke stubs for Unix platforms #24834

Merged
merged 9 commits into from
Jun 6, 2019
Merged

Conversation

fadimounir
Copy link

@fadimounir fadimounir commented May 29, 2019

Enables inlining of PInvoke stubs for Unix platforms

@fadimounir fadimounir added the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label May 29, 2019
src/vm/amd64/pinvokestubs.S Outdated Show resolved Hide resolved
src/vm/amd64/pinvokestubs.S Outdated Show resolved Hide resolved
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests/src/JIT/MyRepro/test.cs Outdated Show resolved Hide resolved
@fadimounir fadimounir force-pushed the pinvokes_unix branch 3 times, most recently from 30d12a8 to 1e0841f Compare June 3, 2019 18:00
@fadimounir fadimounir changed the title WIP - PInvoke stubs for Unix platforms PInvoke stubs for Unix platforms Jun 3, 2019
@fadimounir fadimounir removed the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Jun 3, 2019
@fadimounir
Copy link
Author

@janvorli Could you please review? The changes should be ready to merge. Thanks!

@fadimounir fadimounir requested a review from janvorli June 3, 2019 23:33
@fadimounir fadimounir added area-ReadyToRun os-linux Linux OS (any supported distro) labels Jun 3, 2019
@fadimounir fadimounir added this to the 3.0 milestone Jun 3, 2019
src/vm/amd64/pinvokestubs.S Outdated Show resolved Hide resolved
src/vm/amd64/pinvokestubs.S Outdated Show resolved Hide resolved
src/vm/arm64/pinvokestubs.S Outdated Show resolved Hide resolved
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

src/vm/arm64/pinvokestubs.S Outdated Show resolved Hide resolved
src/vm/arm64/pinvokestubs.S Outdated Show resolved Hide resolved
Fadi Hanna and others added 2 commits June 4, 2019 17:01
Co-Authored-By: Jan Kotas <jkotas@microsoft.com>
Co-Authored-By: Jan Kotas <jkotas@microsoft.com>
@fadimounir fadimounir merged commit 9f76c18 into dotnet:master Jun 6, 2019
@fadimounir fadimounir deleted the pinvokes_unix branch July 1, 2019 19:46
@xiangzhai
Copy link

:mips-interest

picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Enable pinvoke stub inlining on Unix
Exclude x86 Unix platforms from inlining pinvoke stubs (limited support)



Commit migrated from dotnet/coreclr@9f76c18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-ReadyToRun os-linux Linux OS (any supported distro)
Projects
None yet
5 participants