Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PInvoke stubs for Unix platforms #24834

Merged
merged 9 commits into from Jun 6, 2019
Merged

Conversation

@fadimounir
Copy link

@fadimounir fadimounir commented May 29, 2019

Enables inlining of PInvoke stubs for Unix platforms

src/vm/amd64/pinvokestubs.S Outdated Show resolved Hide resolved
src/vm/amd64/pinvokestubs.S Outdated Show resolved Hide resolved
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

tests/src/JIT/MyRepro/test.cs Outdated Show resolved Hide resolved
@fadimounir fadimounir force-pushed the pinvokes_unix branch 3 times, most recently from 30d12a8 to 1e0841f Jun 3, 2019
@fadimounir fadimounir changed the title WIP - PInvoke stubs for Unix platforms PInvoke stubs for Unix platforms Jun 3, 2019
@fadimounir
Copy link
Author

@fadimounir fadimounir commented Jun 3, 2019

@janvorli Could you please review? The changes should be ready to merge. Thanks!

@fadimounir fadimounir requested a review from janvorli Jun 3, 2019
@fadimounir fadimounir added this to the 3.0 milestone Jun 3, 2019
src/vm/amd64/pinvokestubs.S Outdated Show resolved Hide resolved
src/vm/amd64/pinvokestubs.S Outdated Show resolved Hide resolved
src/vm/arm64/pinvokestubs.S Outdated Show resolved Hide resolved
Copy link
Member

@janvorli janvorli left a comment

LGTM, thank you!

src/vm/arm64/pinvokestubs.S Outdated Show resolved Hide resolved
src/vm/arm64/pinvokestubs.S Outdated Show resolved Hide resolved
Fadi Hanna and others added 2 commits Jun 5, 2019
Co-Authored-By: Jan Kotas <jkotas@microsoft.com>
Co-Authored-By: Jan Kotas <jkotas@microsoft.com>
@fadimounir fadimounir merged commit 9f76c18 into dotnet:master Jun 6, 2019
37 checks passed
@fadimounir fadimounir deleted the pinvokes_unix branch Jul 1, 2019
@xiangzhai
Copy link

@xiangzhai xiangzhai commented Sep 5, 2019

:mips-interest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants