Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PInvoke stubs for Unix platforms #24834

Merged
merged 9 commits into from Jun 6, 2019

Conversation

@fadimounir
Copy link
Member

commented May 29, 2019

Enables inlining of PInvoke stubs for Unix platforms

@fadimounir fadimounir force-pushed the fadimounir:pinvokes_unix branch from a4db763 to d4a1cf4 May 29, 2019
src/vm/amd64/pinvokestubs.S Outdated Show resolved Hide resolved
src/vm/amd64/pinvokestubs.S Outdated Show resolved Hide resolved
@fadimounir fadimounir force-pushed the fadimounir:pinvokes_unix branch from 09c6b74 to a8bcfb3 May 29, 2019
Copy link
Member

left a comment

tests/src/JIT/MyRepro/test.cs Outdated Show resolved Hide resolved
@fadimounir fadimounir force-pushed the fadimounir:pinvokes_unix branch 3 times, most recently from 30d12a8 to 1e0841f May 30, 2019
@fadimounir fadimounir changed the title WIP - PInvoke stubs for Unix platforms PInvoke stubs for Unix platforms Jun 3, 2019
@fadimounir fadimounir removed the * NO MERGE * label Jun 3, 2019
@fadimounir fadimounir force-pushed the fadimounir:pinvokes_unix branch from 1e0841f to b2f882b Jun 3, 2019
@fadimounir

This comment has been minimized.

Copy link
Member Author

commented Jun 3, 2019

@janvorli Could you please review? The changes should be ready to merge. Thanks!

@fadimounir fadimounir requested a review from janvorli Jun 3, 2019
@fadimounir fadimounir added this to the 3.0 milestone Jun 3, 2019
src/vm/amd64/pinvokestubs.S Outdated Show resolved Hide resolved
src/vm/amd64/pinvokestubs.S Outdated Show resolved Hide resolved
src/vm/arm64/pinvokestubs.S Outdated Show resolved Hide resolved
Copy link
Member

left a comment

LGTM, thank you!

src/vm/arm64/pinvokestubs.S Outdated Show resolved Hide resolved
src/vm/arm64/pinvokestubs.S Outdated Show resolved Hide resolved
fadimounir and others added 2 commits Jun 5, 2019
Co-Authored-By: Jan Kotas <jkotas@microsoft.com>
Co-Authored-By: Jan Kotas <jkotas@microsoft.com>
@fadimounir fadimounir merged commit 9f76c18 into dotnet:master Jun 6, 2019
37 checks passed
37 checks passed
WIP Ready for review
Details
coreclr-ci Build #20190604.61 succeeded
Details
coreclr-ci (Build Linux arm checked) Build Linux arm checked succeeded
Details
coreclr-ci (Build Linux arm64 checked) Build Linux arm64 checked succeeded
Details
coreclr-ci (Build Linux arm64 release) Build Linux arm64 release succeeded
Details
coreclr-ci (Build Linux_musl x64 checked) Build Linux_musl x64 checked succeeded
Details
coreclr-ci (Build Linux_musl x64 release) Build Linux_musl x64 release succeeded
Details
coreclr-ci (Build Linux_rhel6 x64 release) Build Linux_rhel6 x64 release succeeded
Details
coreclr-ci (Build Windows_NT arm Checked) Build Windows_NT arm Checked succeeded
Details
coreclr-ci (Build Windows_NT arm64 Checked) Build Windows_NT arm64 Checked succeeded
Details
coreclr-ci (Build Windows_NT x64 Checked) Build Windows_NT x64 Checked succeeded
Details
coreclr-ci (Build Windows_NT x64 Debug) Build Windows_NT x64 Debug succeeded
Details
coreclr-ci (Build Windows_NT x86 Checked) Build Windows_NT x86 Checked succeeded
Details
coreclr-ci (Build Windows_NT x86 Debug) Build Windows_NT x86 Debug succeeded
Details
coreclr-ci (Formatting Linux x64) Formatting Linux x64 succeeded
Details
coreclr-ci (Formatting Windows_NT x64) Formatting Windows_NT x64 succeeded
Details
coreclr-ci (Test Pri0 Linux arm64_checked) Test Pri0 Linux arm64_checked succeeded
Details
coreclr-ci (Test Pri0 Linux arm_checked) Test Pri0 Linux arm_checked succeeded
Details
coreclr-ci (Test Pri0 Linux x64_checked) Test Pri0 Linux x64_checked succeeded
Details
coreclr-ci (Test Pri0 Linux_musl x64_checked) Test Pri0 Linux_musl x64_checked succeeded
Details
coreclr-ci (Test Pri0 Linux_musl x64_release) Test Pri0 Linux_musl x64_release succeeded
Details
coreclr-ci (Test Pri0 OSX x64_checked) Test Pri0 OSX x64_checked succeeded
Details
coreclr-ci (Test Pri0 Windows_NT arm64_checked) Test Pri0 Windows_NT arm64_checked succeeded
Details
coreclr-ci (Test Pri0 Windows_NT arm_checked) Test Pri0 Windows_NT arm_checked succeeded
Details
coreclr-ci (Test Pri0 Windows_NT x64_checked) Test Pri0 Windows_NT x64_checked succeeded
Details
coreclr-ci (Test Pri0 Windows_NT x86_checked) Test Pri0 Windows_NT x86_checked succeeded
Details
coreclr-ci (Test Pri0 CoreFX Windows_NT x64_release) Test Pri0 CoreFX Windows_NT x64_release succeeded
Details
coreclr-ci (Test Pri0 R2R Linux x64_checked) Test Pri0 R2R Linux x64_checked succeeded
Details
coreclr-ci (Test Pri0 R2R OSX x64_checked) Test Pri0 R2R OSX x64_checked succeeded
Details
coreclr-ci (Test Pri0 R2R Windows_NT x64_checked) Test Pri0 R2R Windows_NT x64_checked succeeded
Details
coreclr-ci (Test Pri0 R2R Windows_NT x86_checked) Test Pri0 R2R Windows_NT x86_checked succeeded
Details
coreclr-ci (build Linux x64 Checked) build Linux x64 Checked succeeded
Details
coreclr-ci (build OSX x64 Checked) build OSX x64 Checked succeeded
Details
coreclr-ci (build Windows_NT arm Release) build Windows_NT arm Release succeeded
Details
coreclr-ci (build Windows_NT arm64 Release) build Windows_NT arm64 Release succeeded
Details
coreclr-ci (build Windows_NT x64 Release) build Windows_NT x64 Release succeeded
Details
license/cla All CLA requirements met.
Details
@fadimounir fadimounir deleted the fadimounir:pinvokes_unix branch Jul 1, 2019
@xiangzhai

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2019

:mips-interest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.