Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Fix some nullable annotations from API Review #24937

Merged
merged 5 commits into from
Jun 5, 2019
Merged

Fix some nullable annotations from API Review #24937

merged 5 commits into from
Jun 5, 2019

Conversation

safern
Copy link
Member

@safern safern commented Jun 4, 2019

I fixed the annotations that we found out were wrong during API Reviews and also enabled CS8609 (covariant overriden return type) globally and disabled in places where we intentionally are overriding with a different return type.

Also, fixed some annotations in MethodInfo based on an offline conversation with @jkotas

Here are the notes from the review: https://github.com/dotnet/apireviews/blob/b2a7fcaf18d92267cf41258205e55ad0dd1b2a41/2019/System.Runtime-Nullable/README.md

@safern safern requested a review from a team June 4, 2019 00:21
@safern safern force-pushed the FixNullableAnnotationsApiReview branch from d37edc4 to 6fa8467 Compare June 4, 2019 06:42
@safern safern force-pushed the FixNullableAnnotationsApiReview branch from 6fa8467 to 9d98b48 Compare June 4, 2019 06:45
@safern
Copy link
Member Author

safern commented Jun 4, 2019

I just finished addressing PR Feedback. Would you guys mind taking another look?

@safern safern force-pushed the FixNullableAnnotationsApiReview branch from 560de78 to b9e65b9 Compare June 4, 2019 22:27
@safern safern mentioned this pull request Jun 5, 2019
Merged
@safern
Copy link
Member Author

safern commented Jun 5, 2019

I put up a PR to fix the tests in corefx: dotnet/corefx#38269

Will push a commit to disable those tests here in coreclr.

@safern safern merged commit a64cb0a into dotnet:master Jun 5, 2019
@safern safern deleted the FixNullableAnnotationsApiReview branch June 5, 2019 22:55
@mjsabby
Copy link

mjsabby commented Jun 6, 2019

@safern You did not click "Squash and merge", please try to do that if this is not intentional which from the commit descriptions does not seem like it.

@safern
Copy link
Member Author

safern commented Jun 6, 2019

Damn it. Sorry again.

@EgorBo EgorBo mentioned this pull request Jun 28, 2019
Merged
@MaximLipnin MaximLipnin mentioned this pull request Jan 30, 2020
Open
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@safern
Merge pull request dotnet/coreclr#24937 from safern/FixNullableAnnota…
71a30cd 
…tionsApiReview

Fix some nullable annotations from API Review

Commit migrated from dotnet/coreclr@a64cb0a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ANahr ANahr ANahr left review comments

@stephentoub stephentoub stephentoub left review comments

@jkotas jkotas jkotas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@safern @mjsabby @ANahr @stephentoub @jkotas