This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.0] Port recent nullability updates #25759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove !s and TODO-NULLABLE comments for [DoesNotReturn] * Remove !s and TODO-NULLABLE comments for [NotNullIfNotNull] * Remove !s and TODO-NULLABLE comments for writes via Interlocked.CompareExchange * Remove !s and TODO-NULLABLE comments for Debug.Assert on fields * Update/add several TODO-NULLABLE comments
Late-breaking design change: all events should be declared with nullable delegate types.
|
@danmosemsft signed off on this in #25752 (comment), as well as offline verbally for the !s/comments changes to minimize future conflicts with ports. |
|
Agreed. Is this the last though? |
The last what? |
haha, I mean the last set of annotation adjustments you expect in the near future. |
|
It's the last we know about. Can't promise something else won't come up. This came about because of a bug fix in Roslyn that started triggering warnings we didn't expect, and it snowballed from there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @danmosemsft, @safern, @wtgodbe, @agocke
This ports dbc0e19, 45e4834, and 8ba2e15 to release/3.0. The third one changes the public nullable annotations around events exposed from corelib, based on recent design decisions on how we want to handle events and nullability. The second one touches some of the same code, but more generally it's just removing a bunch of now unnecessary
!s and// TODO-NULLABLEcomments, and is likely to result in conflicts in the future given the number of lines it touches, so it's better to get it into the release branch given it's not impacting anything meaningful. The first one is mostly overwritten by the third one, and so porting it results in the most automated process. All three were cherry-picked, with no conflicts and no further manual changes quired.The final commit is required to update the compiler used in the release branch to one with additional nullability fixes that allows all this to work.
After this, @safern will submit corresponding PRs to corefx, both master and release/3.0 branches, to update the corresponding ref assemblies.