Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Delete stale test exclusion files #27375

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Oct 22, 2019

The .txt exclusion files do not appear to be used and maintained anymore.

@jkotas
Copy link
Member Author

jkotas commented Oct 22, 2019

cc @dotnet/coreclr-infra

@jashook
Copy link

jashook commented Oct 22, 2019

I believe keeping these around for bringup_runtest.sh is useful.

@AaronRobinsonMSFT
Copy link
Member

AaronRobinsonMSFT commented Oct 22, 2019

I believe keeping these around for bringup_runtest.sh is useful.

If these aren't being maintained, I don't see how.

Ideally bring up for new platforms should be a very short period of time. Additionally instead of indicating what shouldn't be run/pass, we should indicate what should be executed to actually validate what we expect is supported is.

@jkotas
Copy link
Member Author

jkotas commented Oct 22, 2019

I have noticed these files since they have references to a lot of already fixed issues.

The platform bring up usually starts with a small list of smoke tests. None of these lists that I am deleting is such list.

@jashook
Copy link

jashook commented Oct 23, 2019

I would check with samsung to see if they are still using the arm related excludes

@jashook
Copy link

jashook commented Oct 23, 2019

https://github.com/dotnet/coreclr/blob/master/tests/scripts/arm32_ci_script.sh used to be their old way of running testing which still would reference bringup_runtest.sh, and in turn I think pull in the arm files.

@jkotas
Copy link
Member Author

jkotas commented Oct 23, 2019

@alpencolt Are you using any of these exclusion files for your test runs?

@jkotas
Copy link
Member Author

jkotas commented Oct 23, 2019

@dotnet/coreclr-infra "coreclr-ci (Run Test Pri0 CoreFX Windows_NT x64 checked)" leg failed and produced a dump. How do I download the dump locally?

@AaronRobinsonMSFT
Copy link
Member

@jkotas Go to AzDO via the details links. Find the test tabs. goto the test, look in the Attachments tag and download the HTML log. Within the log will be a URL for the DMP file.

@AaronRobinsonMSFT
Copy link
Member

@jkoritzinsky can you help @jkotas. There has been some confusion about this process recently.

@jkoritzinsky
Copy link
Member

The documentation for how to pull down a dump is located at https://github.com/dotnet/arcade/blob/master/Documentation/Dumps/Dumps.md.

The dump from the job you mentioned is at https://helix.dot.net/api/2019-06-17/jobs/22db89b3-4765-40d9-bc95-a0ca9db0faf0/workitems/System.Transactions.Local.Tests/files/5568.3jnw3dju.yvt.dmp

@BruceForstall
Copy link
Member

@jkoritzinsky Maybe there should be a doc in dotnet/coreclr that links to that arcade doc?

It would also be useful to the documentation to specify how to get the appropriate symbols for the dump.

@alpencolt
Copy link

@alpencolt Are you using any of these exclusion files for your test runs?

@jkotas yes, we still use old testing scripts since have to execute corerun and use all this testsUnsupported-, testsFailing-, and other files.
We're going to use new scheme but it's needed to make dotnet tool for Tizen first.

Don't mind if you remove this files, we can keep them locally.

@jkotas
Copy link
Member Author

jkotas commented Oct 23, 2019

@alpencolt Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
6 participants