This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.1] Fix non-portable distrorid alpine generation #28227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayakael
changed the title
hoyosjs
approved these changes
Jan 21, 2022
There was a problem hiding this comment.
This LGTM in technical terms, but 3.1 is a protected branch - @jeffschwMSFT and @dotnet/source-build-internal is this something that's needed in 3.1? I don't know if we have non-portable commitments here or if it's OK for 3.1; this is very low risk as it explicitly needs to ask for a non-portable build.
|
@safern this is a tell mode infra change. When is ok to merge? Thanks |
|
@jeffschwMSFT the branch will be open ~4th February until the 7th |
|
Marking approved (for tell mode) so that we merge once the branch is open. |
|
Perfect, many thanks! |
|
Branch is now open for servicing approved changes. The OSX x64 CI failure seems unrelated to alpine. Sign-off received, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
init-distro-id.sh generates incorrect DistroRid on Alpine. While the expected DistroRid (alpine-x.xx-xxx) should only include macro version, init-distro-id.sh includes the micro version. This patches it to cut off the trailing subversion off of VERSION_ID by treating it the same way RHEL's VERSION_ID is treated.
Made as part of Alpine Linux dotnet31 / dotnet5 packaging project, see dotnet/source-build#2695