Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Update Linux Build Instruction #3923

Merged
merged 1 commit into from
Mar 25, 2016
Merged

Update Linux Build Instruction #3923

merged 1 commit into from
Mar 25, 2016

Conversation

myungjoo
Copy link

For Linux/ARM, you need to update libunwind-arm
in order to avoid segmentation faults in libunwind-arm,
which is not included in major Linux distros, yet,
while it is already being addressed in upstreams.

This is realted with #3898 Issue Comment 201098037:
https://github.com/dotnet/coreclr/issues/3898#issuecomment-201098037

Signed-off-by: MyungJoo Ham myungjoo.ham@samsung.com

For Linux/ARM, you need to update libunwind-arm
in order to avoid segmentation faults in libunwind-arm,
which is not included in major Linux distros, yet,
while it is already being addressed in upstreams.

This is realted with #3898 Issue Comment 201098037:
https://github.com/dotnet/coreclr/issues/3898#issuecomment-201098037

Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
@seanshpark
Copy link

thanks!

@jkotas
Copy link
Member

jkotas commented Mar 25, 2016

LGTM. Thanks!

@jkotas jkotas merged commit 58209af into dotnet:master Mar 25, 2016
@manu-st
Copy link

manu-st commented Mar 25, 2016

@myungjoo Are you sure you need the protection on write too?

@myungjoo
Copy link
Author

@manu-silicon Yes, with test runs of coreclr in ARM/Linux, I've witnessed a case where I've got a segmentation fault with access_mem/write. Please refer this as well (from line 75,static int
access_mem(...) ): https://android.googlesource.com/platform/external/libunwind/+/master/src/arm/Ginit.c

I'd like to test with android-libunwind installed instead of the default libunwind in non-Android machines for CORECLR later. (if somebody has done that, please share the results :) )

@manu-st
Copy link

manu-st commented Mar 25, 2016

Curious to see that upstream libunwind is not doing the protection. Maybe we should contact them so that they add the protection too.

@BruceForstall
Copy link
Member

@myungjoo Is this documentation still valid, or can I remove it?

@myungjoo
Copy link
Author

myungjoo commented Jul 5, 2018

@BruceForstall If you are using libunwind 1.3 or later, it is no more required.

If you are building with libunwind < 1.3, this is still valid.

Note that libunwind has release 1.3 stable 3 months ago.

picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
6 participants