This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Use BIT64 define for 64-bit specific code. #5987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using WIN32/WIN64 for 32/64-bit architecture dependent code confuses developers especially those who develop coreclr for non-Windows systems. Therefore, such definitions are modified to BIT64. Fixes #4737 Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
|
@dotnet-bot Test CentOS7.1 x64 Debug Build and Test Please |
|
LGTM. Thanks! |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Using WIN32/WIN64 for 32/64-bit architecture dependent code confuses developers especially those who develop coreclr for non-Windows systems. Therefore, such definitions are modified to BIT64. Fixes dotnet/coreclr#4737 Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com> Commit migrated from dotnet/coreclr@99c0410
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using WIN32/WIN64 for 32/64-bit architecture dependent code confuses
developers especially those who develop coreclr for non-Windows
systems. Therefore, such definitions are modified to BIT64.
Fixes #4737
Signed-off-by: MyungJoo Ham myungjoo.ham@samsung.com