Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Add Tizen rootfs for armel #8781

Merged
merged 3 commits into from Jan 5, 2017
Merged

Conversation

hqueue
Copy link
Member

@hqueue hqueue commented Jan 3, 2017

Add Tizen rootfs for arm-softfp which is also used for arm cross CI.

Update rootfs script for arm-softfp and cmake file.

Now we have two rootfs for arm-softfp, Debian 8 and Tizen and we can make rootfs as follows.

  • Debian 8 "jessie" (default)
    $ sudo ./cross/build-rootfs.sh armel

  • Tizen (new)
    $ sudo ./cross/build-rootfs.sh armel tizen

For more detail about rootfs, see https://github.com/dotnet/coreclr/blob/master/Documentation/building/cross-building.md#generating-the-rootfs

BTW there are another issue and pr about chainging name of arm-softfp port to armel. (issue #8770, pr #8771). This PR and PR #8771 conflict each other and we will rebase one of two when either one is merged.

@hqueue
Copy link
Member Author

hqueue commented Jan 4, 2017

This is a part of core-setup issue "Enabling Linux ARM32 for .NET Core" https://github.com/dotnet/core-setup/issues/725 .

elif [ "$__Tizen" == "tizen" ]; then
ROOTFS_DIR=$__RootfsDir $__CrossDir/$__BuildArch/tizen-build-rootfs.sh
else
echo "Something wrong"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest changing this message to something like Unsupported target platform.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gkhanna79 I will update message when rebase this PR to upstream.

@gkhanna79
Copy link
Member

Changes look good. Could you please rebase this once the other PR goes through?

@hqueue
Copy link
Member Author

hqueue commented Jan 5, 2017

I will rebase it after other PR is merged.

@hqueue hqueue force-pushed the arm/rootfs/tizen branch 3 times, most recently from fd3a8f7 to 6455a1d Compare January 5, 2017 06:34
@hqueue
Copy link
Member Author

hqueue commented Jan 5, 2017

@gkhanna79 I've rebased with PR for armel. First two commits are from PR for armel and updated message as you suggested. I think we can merge this if previous PR is merged without problem.

@hqueue hqueue changed the title Add Tizen rootfs for arm-softfp Add Tizen rootfs for armel Jan 5, 2017
@hqueue
Copy link
Member Author

hqueue commented Jan 5, 2017

I'm now rebasing this PR.

hqueue and others added 3 commits January 5, 2017 18:44
- This rootfs can be used for CoreCLR, CoreFX and Core-Setup.

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Fetch packages for build RootFS by XML information in download.tizen.org

Signed-off-by: pius.lee <pius.lee@samsung.com>
Enable build using Tizen rootfs

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
@hqueue
Copy link
Member Author

hqueue commented Jan 5, 2017

@dotnet-bot test Linux ARM Emulator Cross Release Build

@hqueue
Copy link
Member Author

hqueue commented Jan 5, 2017

@dotnet-bot test OSX x64 Checked Build and Test

@hqueue
Copy link
Member Author

hqueue commented Jan 5, 2017

@gkhanna79 At last, I think this PR is ready by now, i.e. previous PR is merged, this PR is rebased with upstream and all CI tests are passed. PTAL.

@gkhanna79
Copy link
Member

@hqueue Can this be merged?

@hqueue
Copy link
Member Author

hqueue commented Jan 5, 2017

@gkhanna79 Yes. Please merge this :)

@gkhanna79 gkhanna79 merged commit 871448a into dotnet:master Jan 5, 2017
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants