Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

[x86/Linux] Fix EH region mismatch #9043

Merged
merged 1 commit into from Jan 24, 2017

Conversation

parjong
Copy link

@parjong parjong commented Jan 23, 2017

This commit ports ARM EH region mismatch fix (#6088) into x86 in order to fix #9042.

@parjong
Copy link
Author

parjong commented Jan 23, 2017

\CC @seanshpark @wateret

@parjong parjong changed the title [x86/Linux] Fix EH Region Mismatch [x86/Linux] Fix EH region mismatch Jan 23, 2017
@parjong
Copy link
Author

parjong commented Jan 23, 2017

@dotnet-bot test Windows_NT x64 Debug Build and Test please

@parjong
Copy link
Author

parjong commented Jan 23, 2017

@janvorli Please take a look.

@jkotas
Copy link
Member

jkotas commented Jan 24, 2017

@parjong This one has a conflict now...

@parjong
Copy link
Author

parjong commented Jan 24, 2017

@dotnet-bot test Windows_NT x64 Debug Build and Test please

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli
Copy link
Member

@jkotas I wonder why we don't have to do the same thing for AMD64. Is the jitter codegen different in this respect?

@parjong
Copy link
Author

parjong commented Jan 24, 2017

@janvorli As I remember, ARM64 (and AMD64?) jitter appends a dummy instruction if

  • call is the last instruction of a basic block, and
  • that basic block and the next basic block are not in the same eh region.

(discovered while working on #4503)

@janvorli
Copy link
Member

@parjong thank you, that added dummy instruction explains it then.

@janvorli janvorli merged commit 617c0cf into dotnet:master Jan 24, 2017
@parjong parjong deleted the fix/x86_eh_mismatch branch January 24, 2017 12:50
@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants