This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
\CC @seanshpark @wateret |
parjong
changed the title
[x86/Linux] Fix EH Region Mismatch
[x86/Linux] Fix EH region mismatch
Jan 23, 2017
@dotnet-bot test Windows_NT x64 Debug Build and Test please |
@janvorli Please take a look. |
@parjong This one has a conflict now... |
parjong
force-pushed
the
fix/x86_eh_mismatch
branch
from
January 24, 2017 06:55
4160ea5
to
afa3340
Compare
@dotnet-bot test Windows_NT x64 Debug Build and Test please |
janvorli
approved these changes
Jan 24, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
@jkotas I wonder why we don't have to do the same thing for AMD64. Is the jitter codegen different in this respect? |
@parjong thank you, that added dummy instruction explains it then. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Commit migrated from dotnet/coreclr@617c0cf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ports ARM EH region mismatch fix (#6088) into x86 in order to fix #9042.