Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Commit

Permalink
Fix framework package validation build (#32562)
Browse files Browse the repository at this point in the history
When using AfterTargets="Build" msbuild does not let a failing target effect the result
of the called target (build) since the called target and its closure did not fail.

Instead, sequence our targets in the closure of "Build" so that a failing target will
propagate to the build result.
  • Loading branch information
ericstj authored and ViktorHofer committed Oct 4, 2018
1 parent ad53f46 commit 4488685
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions pkg/frameworkPackage.targets
Expand Up @@ -109,7 +109,7 @@

<Target Name="VerifyClosure"
DependsOnTargets="GetClosureFiles"
AfterTargets="Build"
AfterTargets="ValidatePackage"
Inputs="%(ClosureFile.FileSet)"
Outputs="batching-on-FileSet-metadata">
<ItemGroup>
Expand All @@ -129,7 +129,7 @@

<Target Name="VerifyDuplicateTypes"
DependsOnTargets="GetClosureFiles"
AfterTargets="Build"
AfterTargets="ValidatePackage"
Inputs="%(ClosureFile.FileSet)"
Outputs="batching-on-FileSet-metadata">
<PropertyGroup>
Expand All @@ -154,7 +154,7 @@

<Target Name="VerifyNETStandard"
DependsOnTargets="GetClosureFiles"
AfterTargets="Build"
AfterTargets="ValidatePackage"
Inputs="%(ClosureFile.FileSet)"
Outputs="batching-on-FileSet-metadata">

Expand Down

0 comments on commit 4488685

Please sign in to comment.