Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null Reference when trying to add a cert to a store after calling dispose on the cert #18792

Closed
Petermarcu opened this issue Sep 30, 2016 · 1 comment
Closed

Null Reference when trying to add a cert to a store after calling dispose on the cert #18792

Petermarcu opened this issue Sep 30, 2016 · 1 comment
Labels
area-System.Security disabled-test The test is disabled in source code against the issue help wanted [up-for-grabs] Good issue for external contributors test-enhancement Improvements of test source code
Milestone
2.0.0

Comments

@Petermarcu
Copy link
Member

See this test fix for more details: dotnet/corefx#12220

As part of this fix we should also consider whether we need to add a test case to cover the scenario where a cert does not have a private key in our tests.
@bartonjs
Copy link
Member

Based on http://referencesource.microsoft.com/#System/security/system/security/cryptography/cryptoapi.cs,5bbb563f5bb1034c, ArgumentNullException is actually the best match (our null Pal object is scenario-equivalent to a null safehandle).

@bartonjs bartonjs removed their assignment Nov 9, 2016
jmezach referenced this issue in jmezach/corefx Apr 11, 2017
Verify handle when adding certificate
a67ff19 
Make sure we verify that a certificate's handle is valid before adding it to the store.

Fix #12223
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.0.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Security disabled-test The test is disabled in source code against the issue help wanted [up-for-grabs] Good issue for external contributors test-enhancement Improvements of test source code
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
3 participants
@Petermarcu @msftgits @bartonjs