Remove versioned defines

[danmoseley]

We should migrate to versionless platform defines. @joperezr @weshaggard can we do this now if not what has to come first? I see you already renamed all the C# file suffixes to be versionless.

• #if netcoreapp11 --> #if netcoreapp
• #if netstandard17, #if netstandard10 --> #if netstandard
• #if netcore50 --> #if uap
• #if netcore50aot --> #if uapaot

incidentally
#if NET46 -> don't change

• # if NET_4_5 -> dead

Perhaps you already have something tracking this kind of thing.

[weshaggard]

We can do that for all the test projects because we don't care about the versioned target frameworks for those projects. However we might still need to keep some of these for the ref/src projects if we care about that build configuration for that project.

[danmoseley]

Can you clarify? I thought we now only build ref/src for the latest version. So we would never define eg netcoreapp11 would we?

[weshaggard]

For ref/src that ship as an individual nuget package we may need to still have non-latest build configurations building so that the package can contain the correct assets. For anything that doesn't ship in an individual package you are correct they should always just target the latest (i.e. versionless) targets.

[danmoseley]

Ah, so we go back to the issue of clearly distinguishing what is its own package. It's too bad we don't segreate the rest of corefx from those.

[danmoseley]

I thought we doing harvesting for non latest configurations.

[weshaggard]

Ah, so we go back to the issue of clearly distinguishing what is its own package. It's too bad we don't segreate the rest of corefx from those.

Unfortunately it is a clean cut in all cases. Consider Immutable collections it is ships in the platform package and in an individual package.

I thought we doing harvesting for non latest configurations.

We do in a lot of cases but in some cases, again like Immutable, we still want to produce live updated builds with new fixes for older targets.

[jkotas]

I think #if netstandard should be deleted (and code under it kept). I do not think we need it.

[weshaggard]

I think #if netstandard should be deleted (and code under it kept). I do not think we need it.

I agree in general the defines should be targeting a specific platform (i.e. netcoreapp, uap, netfx, etc) however there may be cases for libraries above netstandard to use that define in some cases if it is easier then negating the other specific platforms.

[jkotas]

there may be cases for libraries above netstandard to use that define in some cases if it is easier then negating the other specific platforms.

Agree it makes sense to use it in these cases if they show up.

[jkotas]

The defines are in sync with the SDK ones now.