Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImmutableInterlockedTests.InterlockedCompareExchangeArrayDefault has no assertions #20621

Closed
sharwell opened this issue Mar 14, 2017 · 2 comments
Closed

ImmutableInterlockedTests.InterlockedCompareExchangeArrayDefault has no assertions #20621

sharwell opened this issue Mar 14, 2017 · 2 comments
Labels
area-System.Collections test-enhancement Improvements of test source code
Milestone
2.0.0

Comments

@sharwell
Copy link
Member

The ImmutableInterlockedTests.InterlockedCompareExchangeArrayDefault test is missing assertions, so while it provides some code coverage it's not currently able to reveal bugs aside from exceptions. Assertions regarding oldValue should probably be added to improve the quality of this test.
@karelz
Copy link
Member

karelz commented Mar 14, 2017

@sharwell do you plan to submit a PR?

@sharwell
Copy link
Member Author

@karelz Not at this time. I found the issue while working on a Java port of the library (specifically tunnelvisionlabs/java-immutable#40).

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.0.0 milestone Jan 31, 2020
@dotnet dotnet locked as resolved and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Collections test-enhancement Improvements of test source code
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
3 participants
@sharwell @karelz @msftgits