Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.IO.Pipes.Tests.Perf_PipeTest hangs on Unix #21074

Closed
mellinoe opened this issue Apr 12, 2017 · 5 comments
Closed

System.IO.Pipes.Tests.Perf_PipeTest hangs on Unix #21074

mellinoe opened this issue Apr 12, 2017 · 5 comments
Labels
area-System.IO os-linux Linux OS (any supported distro) test-bug Problem in test source code (most likely)
Milestone

Comments

@mellinoe
Copy link
Contributor

This test seems to hang when run on Unix. There are a couple of threads waiting on PipeStream writes and socket loops. To repro, just run this test project:

Tools/msbuild.sh src/System.IO.Pipes/tests/Performance/System.IO.Pipes.Performance.Tests.csproj /t:rebuildandtest /p:outerloop=true
@stephentoub
Copy link
Member

No tests are currently hanging.

@wfurt
Copy link
Member

wfurt commented Jan 30, 2020

It seems like this is because it is disabled in the base class.

    [AllowedOperatingSystems("Hangs on non-Windows, dotnet/corefx#18290", OS.Windows)]
    [BenchmarkCategory(Categories.Libraries)]
    public abstract class Perf_PipeTest : PipeTestBase

When I remove that test hangs on my Ubuntu 18.04. I will take a look.

@wfurt wfurt reopened this Jan 30, 2020
@stephentoub
Copy link
Member

Ugh. Thanks

@wfurt
Copy link
Member

wfurt commented Jan 30, 2020

It seems like it was dotnet/performance#56. I tried to move this to perf repo but I did not figure out how. Corefx/runtime tests do all pass so it seems like a problem with the perf test.

@wfurt
Copy link
Member

wfurt commented Jan 31, 2020

It seems like a test bug in perf repo. Closing since there is nothing left here.
I'll reopen dotnet/performance#56 and I'll submit fix there.

@wfurt wfurt closed this as completed Jan 31, 2020
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 3.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.IO os-linux Linux OS (any supported distro) test-bug Problem in test source code (most likely)
Projects
None yet
Development

No branches or pull requests

4 participants