Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation on Marshal.GetLastWin32Error should be updated. #22540

Closed
tannergooding opened this issue Jun 28, 2017 · 4 comments
Closed

Documentation on Marshal.GetLastWin32Error should be updated. #22540

tannergooding opened this issue Jun 28, 2017 · 4 comments
Labels
area-System.Runtime.InteropServices documentation Documentation bug or enhancement, does not impact product or test code
Milestone
2.1.0

Comments

@tannergooding
Copy link
Member

The documentation currently makes no mention that this method will return errno on Unix/Mac (or the conditions, if any, under which it will return errno on Windows).
@tannergooding
Copy link
Member Author

As an aside, GetLastWin32Error is really a terrible name for cross-platform use. Maybe adding a new API GetLastError would be better...

@mellinoe
Copy link
Contributor

Many of the function names in Marshal are Windows-specific. There was some effort to introduce a PInvokeMarshal class which had better, platform-agnostic names, but I think we decided it wasn't worth it.

@tannergooding
Copy link
Member Author

Fair enough.

At the very least, documenting interop/marshalling functions with the behavior they take on non-Windows would be very beneficial.

@danmoseley
Copy link
Member

Issue moved to dotnet/docs dotnet/corefx#2524 via ZenHub

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.1.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Runtime.InteropServices documentation Documentation bug or enhancement, does not impact product or test code
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
4 participants
@danmoseley @mellinoe @msftgits @tannergooding