Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD: System.Net.NetworkInformation is missing #23714

Closed
wfurt opened this issue Oct 2, 2017 · 4 comments
Closed

FreeBSD: System.Net.NetworkInformation is missing #23714

wfurt opened this issue Oct 2, 2017 · 4 comments
Assignees
Labels
area-System.Net bug help wanted [up-for-grabs] Good issue for external contributors os-freebsd FreeBSD OS
Milestone

Comments

@wfurt
Copy link
Member

wfurt commented Oct 2, 2017

This is part of https://github.com/dotnet/corefx/issues/1626

Many tests failing
System.Net.Ping.Functional.Tests.dll, 7
System.Net.NetworkInformation.Functional.Tests.dll, 31
System.Net.Mail.Functional.Tests.dll, 40

@wfurt wfurt self-assigned this Oct 26, 2017
@karelz karelz unassigned wfurt Jan 5, 2018
@ghost
Copy link

ghost commented Apr 12, 2018

It would probably require us to fill https://github.com/dotnet/corefx/tree/bffef76f6af208e2042a2f27bc081ee908bb390b/src/System.Net.NetworkInformation/src/System/Net/NetworkInformation with:

BsdPAddressInformation.cs
BsdIPGlobalProperties.cs
etc.

@wfurt
Copy link
Member Author

wfurt commented Apr 12, 2018

There are many similarities with OSX. It would probably make sense to consolidate.

@ghost
Copy link

ghost commented Apr 17, 2018

Can we tweak https://github.com/dotnet/corefx/blob/bffef76f6af208e2042a2f27bc081ee908bb390b/src/System.Net.NetworkInformation/src/System.Net.NetworkInformation.csproj#L344 to include BSDs? At the moment, there is:

  <ItemGroup Condition=" '$(TargetsFreeBSD)' == 'true' OR '$(TargetsUnknownUnix)' == 'true' ">
    <Compile Include="System\Net\NetworkInformation\IPGlobalPropertiesPal.UnknownUnix.cs" />
    <Compile Include="System\Net\NetworkInformation\NetworkInterfacePal.UnknownUnix.cs" />
    <Compile Include="System\Net\NetworkInformation\NetworkAddressChange.UnknownUnix.cs" />
  </ItemGroup>

would be cool to check if all the BSDs and macos agree upon same APIs.

@wfurt wfurt self-assigned this Nov 15, 2018
@wfurt
Copy link
Member Author

wfurt commented Dec 13, 2018

remaining work is tracked in dotnet/corefx#33530. this was resolved by dotnet/corefx#33527.

@wfurt wfurt closed this as completed Dec 13, 2018
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 3.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net bug help wanted [up-for-grabs] Good issue for external contributors os-freebsd FreeBSD OS
Projects
None yet
Development

No branches or pull requests

2 participants