[Cookie] CookieCollection should implement ICollection<Cookie>

[geoffkizer]

It implements ICollection, but not ICollection<Cookie>.

Proposed API

    public class CookieCollection : ICollection, ICollection<Cookie>, IReadOnlyCollection<Cookie>
    {
       
        public bool Contains(Cookie c) { }
        
        public void Clear() { }
       
        public bool Remove(Cookie c) { }
        
        public IEnumerator<Cookie> GetEnumerator() { }
       
        IEnumerator IEnumerable.GetEnumerator() { }
     }

@karelz

[davidsh]

Does this need to be reflected in the ref folder, i.e. is this an API change also?

[davidsh]

cc: @stephentoub

[geoffkizer]

Yes. It's basically a feature request, and not high priority. But it seems like we should do it.

[rvhuang]

Aye. It's 2018 already and I see no reason why it shouldn't implement generic collection interface.

[terrajobst]

Video

Looks good but for consistency we should also implement IReadOnlyCollection<>.

[karelz]

Proposal updated.
Should be fairly simple to do. Adding new API into ref (netcore22) will be the trickiest part.

[karelz]

@yevgeniyredko mentioned on gitter he wants to pick this one.
I sent you collaborator invite, so that we can assign the issue to you. Ping me once you accept. Assigning to myself temporarily.
Pro tip: Becoming collaborator will automatically subscribe you to all repo notifications (500+ daily). We recommend to switch repo to "Not Watching" - that will send you notifications only when you are mentioned, explicitly subscribed or assigned issues.

[yevgeniyredko]

@karelz accepted your invite.