Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoreFx still builds packages that have desktop reference assemblies #25858

Closed
ericstj opened this issue Apr 11, 2018 · 4 comments
Closed

CoreFx still builds packages that have desktop reference assemblies #25858

ericstj opened this issue Apr 11, 2018 · 4 comments

Comments

@ericstj
Copy link
Member

ericstj commented Apr 11, 2018

Related https://github.com/dotnet/corefx/issues/23830, part 3

We still have some packages that have reference assemblies in their ref folder. We've found numerous tools that don't like this and shouldn't expect all those tools to get fixed.

As such, we need to tactically remove ref folders, or use the implementation instead in these cases.

@ViktorHofer
Copy link
Member

@joperezr any idea how many packages are affected here?

@joperezr
Copy link
Member

I don't know from the top of my head, but it should be easy to find out how many are there, since all we need to do is to do a build.cmd -allConfigurations and then search in the package nuspecs to find all places where we have "ref/net4" as target path. That said, in order to fully fix this it won't be enough to just remove those, we will also have to find if there any other packages where we have a reference asset for a different framework (like netstandard2.0) which will be used when targeting desktop.

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 23, 2020
@ViktorHofer ViktorHofer removed the untriaged New issue has not been triaged by the area owner label Jun 23, 2020
@ViktorHofer
Copy link
Member

cc @Anipik as you are looking into reducing the number of reference assemblies in package while migrating pkgprojs to csprojs.

@ViktorHofer
Copy link
Member

Closing as we don't include reference assemblies in packages anymore.

Infrastructure Backlog automation moved this from Future to Done Aug 6, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants