Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.IO.FileSystem tests failing on FreeBSD #26726

Closed
wfurt opened this issue Jul 8, 2018 · 0 comments · Fixed by #47994
Closed

System.IO.FileSystem tests failing on FreeBSD #26726

wfurt opened this issue Jul 8, 2018 · 0 comments · Fixed by #47994
Assignees
@adamsitnik
Labels
area-System.IO os-freebsd FreeBSD OS
Projects
Better for Linux System.IO - FileStream
Milestone
6.0.0

Comments

@wfurt
Copy link
Member

wfurt commented Jul 8, 2018 

 /usr/home/furt/git/source-build3/src/corefx/bin/tests/System.IO.FileSystem.Tests/netcoreapp-FreeBSD-Debug-x64 /usr/home/furt/git/source-build3/src/corefx/src/System.IO.FileSystem/tests
  xUnit.net console test runner (64-bit .NET Core)
  Copyright (C) 2014 Outercurve Foundation.

  Discovering: System.IO.FileSystem.Tests
  Discovered:  System.IO.FileSystem.Tests
  Starting:    System.IO.FileSystem.Tests

  Unhandled Exception: Xunit.Sdk.ThrowsException: Assert.Throws() Failure
  Expected: typeof(System.IO.IOException)
  Actual:   (No exception was thrown)
     at Xunit.Assert.Throws(Type exceptionType, Exception exception)
     at Xunit.Assert.Throws[T](Action testCode)
     at System.IO.Tests.FileStream_LockUnlock.<>c.<OverlappingRegionsFromOtherProcess_ThrowsException>b__7_0(String secondPath, String secondPos, String secondLen) in /usr/home/furt/git/source-build3/src/corefx/src/System.IO.FileSystem/tests/FileStream/LockUnlock.cs:line 178
  --- End of stack trace from previous location where exception was thrown ---
     at RemoteExecutorConsoleApp.Program.Main(String[] args) in /usr/home/furt/git/source-build3/src/corefx/src/Common/tests/System/Diagnostics/RemoteExecutorConsoleApp/RemoteExecutorConsoleApp.cs:line 92
  SystemNative_LockFileRegion on 36 with 0x1
     System.IO.Tests.FileStream_LockUnlock.OverlappingRegionsFromOtherProcess_ThrowsException(fileLength: 10, firstPosition: 0, firstLength: 10, secondPosition: 1, secondLength: 2) [FAIL]
        System.Diagnostics.RemoteExecutorTestBase+RemoteInvokeHandle+RemoteExecutionException : Remote process failed with an unhandled exception.
        Stack Trace:

           Child exception:
             Xunit.Sdk.ThrowsException: Assert.Throws() Failure
           Expected: typeof(System.IO.IOException)
           Actual:   (No exception was thrown)
           /usr/home/furt/git/source-build3/src/corefx/src/System.IO.FileSystem/tests/FileStream/LockUnlock.cs(178,0): at System.IO.Tests.FileStream_LockUnlock.<>c.<OverlappingRegionsFromOtherProcess_ThrowsException>b__7_0(String secondPath, String secondPos, String secondLen)

           Child process:
             System.IO.FileSystem.Tests, Version=4.1.1.0, Culture=neutral, PublicKeyToken=9d77cc7ad39b68eb System.IO.Tests.FileStream_LockUnlock+<>c Int32 <OverlappingRegionsFromOtherProcess_ThrowsException>b__7_0(System.String, System.String, System.String)

           Child arguments:
             /tmp/FileStream_LockUnlock_u2fx1sfl.4r0/OverlappingRegionsFromOtherProcess_ThrowsException_167_e7a3c8e1, 1, 2


  Unhandled Exception: Xunit.Sdk.ThrowsException: Assert.Throws() Failure
  Expected: typeof(System.IO.IOException)
  Actual:   (No exception was thrown)
     at Xunit.Assert.Throws(Type exceptionType, Exception exception)
     at Xunit.Assert.Throws[T](Action testCode)
     at System.IO.Tests.FileStream_LockUnlock.<>c.<OverlappingRegionsFromOtherProcess_ThrowsException>b__7_0(String secondPath, String secondPos, String secondLen) in /usr/home/furt/git/source-build3/src/corefx/src/System.IO.FileSystem/tests/FileStream/LockUnlock.cs:line 178
  --- End of stack trace from previous location where exception was thrown ---
     at RemoteExecutorConsoleApp.Program.Main(String[] args) in /usr/home/furt/git/source-build3/src/corefx/src/Common/tests/System/Diagnostics/RemoteExecutorConsoleApp/RemoteExecutorConsoleApp.cs:line 92
  SystemNative_LockFileRegion on 36 with 0x1
     System.IO.Tests.FileStream_LockUnlock.OverlappingRegionsFromOtherProcess_ThrowsException(fileLength: 10, firstPosition: 3, firstLength: 5, secondPosition: 3, secondLength: 5) [FAIL]
        System.Diagnostics.RemoteExecutorTestBase+RemoteInvokeHandle+RemoteExecutionException : Remote process failed with an unhandled exception.
        Stack Trace:

           Child exception:
             Xunit.Sdk.ThrowsException: Assert.Throws() Failure
           Expected: typeof(System.IO.IOException)
           Actual:   (No exception was thrown)
           /usr/home/furt/git/source-build3/src/corefx/src/System.IO.FileSystem/tests/FileStream/LockUnlock.cs(178,0): at System.IO.Tests.FileStream_LockUnlock.<>c.<OverlappingRegionsFromOtherProcess_ThrowsException>b__7_0(String secondPath, String secondPos, String secondLen)

           Child process:
             System.IO.FileSystem.Tests, Version=4.1.1.0, Culture=neutral, PublicKeyToken=9d77cc7ad39b68eb System.IO.Tests.FileStream_LockUnlock+<>c Int32 <OverlappingRegionsFromOtherProcess_ThrowsException>b__7_0(System.String, System.String, System.String)

           Child arguments:
             /tmp/FileStream_LockUnlock_gog4cn0u.lvd/OverlappingRegionsFromOtherProcess_ThrowsException_167_07dedcd6, 3, 5

     System.IO.Tests.FileInfo_Exists.LockedFileExists [FAIL]

All the failing tests are marked with [PlatformSpecific(~TestPlatforms.OSX)] so there is possibility FreeBSD behaves as OSX.
This should be investigated.
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 23, 2020
@JeremyKuhne JeremyKuhne removed the untriaged New issue has not been triaged by the area owner label Mar 3, 2020
@carlossanlop carlossanlop added this to To do in System.IO - File system via automation Mar 6, 2020
@carlossanlop carlossanlop added this to To do in System.IO - FileStream via automation Mar 6, 2020
@carlossanlop carlossanlop added this to Consider in Better for Linux via automation Mar 6, 2020
@carlossanlop carlossanlop removed this from To do in System.IO - File system Mar 6, 2020
@adamsitnik adamsitnik modified the milestones: Future, 6.0.0 Feb 1, 2021
@adamsitnik adamsitnik self-assigned this Feb 8, 2021
adamsitnik added a commit to adamsitnik/runtime that referenced this issue Feb 8, 2021
@adamsitnik
the managed enum Interop.Sys.LockType has no 1:1 mapping with corresp…
8e2ff17 
…onding Unix values

which can be different per distro:
https://github.com/torvalds/linux/blob/fcadab740480e0e0e9fa9bd272acd409884d431a/arch/alpha/include/uapi/asm/fcntl.h#L48-L50
https://github.com/freebsd/freebsd-src/blob/fb8c2f743ab695f6004650b58bf96972e2535b20/sys/sys/fcntl.h#L277-L279

fixes dotnet#26726
@adamsitnik adamsitnik mentioned this issue Feb 8, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Feb 8, 2021
Better for Linux automation moved this from Consider to Done Feb 15, 2021
System.IO - FileStream automation moved this from To do to Done Feb 15, 2021
adamsitnik added a commit that referenced this issue Feb 15, 2021
@adamsitnik
map Interop.Sys.LockType to distro-specific values (#47994)
2437619 
* the managed enum Interop.Sys.LockType has no 1:1 mapping with corresponding Unix values

which can be different per distro:
https://github.com/torvalds/linux/blob/fcadab740480e0e0e9fa9bd272acd409884d431a/arch/alpha/include/uapi/asm/fcntl.h#L48-L50
https://github.com/freebsd/freebsd-src/blob/fb8c2f743ab695f6004650b58bf96972e2535b20/sys/sys/fcntl.h#L277-L279

fixes #26726
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Feb 15, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@adamsitnik adamsitnik

Labels
area-System.IO os-freebsd FreeBSD OS
Projects
Better for Linux
  
Done
System.IO - FileStream
  
Done
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

map Interop.Sys.LockType to distro-specific values adamsitnik/runtime
5 participants
@maryamariyan @adamsitnik @JeremyKuhne @msftgits @wfurt