-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get 8 build errors on Linux #15398
Comments
I'm also seeing this on OSX and Linux. It seems to be the same projects as above |
I am getting same on FreeBSD. Here is the msbuild.log. |
Copying the snippet from @jasonwilliams200OK's log:
I assume the file I'm not at all sure what is happening here. @akoeplinger @ellismg any ideas? My only guess is there is something going on with mono csc here. |
I think @pgavlin was seeing this, but he cleaned and rebuilt and it worked. |
No, I'm still seeing this. Haven't had a chance to investigate yet. |
FWIW, I verified that the key file exists and that it contains the ECMA key. |
Yup the |
I looked into this a little. We don't actually use mono CSC, we use Roslyn and apparently Roslyn has never supported this when running on platforms other than windows (since it calls into mscoree to do stuff), see dotnet/roslyn#2444 for more context. We actually have code to work around this in dir.props by unconditionally setting I will open a PR that modifies the specific projects to only set |
Due to dotnet/roslyn#2444, we have disabled ECMA signing when the host platform for our build is not Windows. This is done by explicitly setting the property in our top level dir.props. Some of the reference assemblies explicitly set UseECMAKey to true, overwriting this value which leads to build breaks when building on non Windows platforms. Guard the setting of this property so that we don't override it if it already set. Fixes #3739
Thanks @ellismg I think this just started to break because we just started to build the ref folders recently (dotnet/corefx@581a773). I suspect it has been broken since then. |
Thanks @ellismg! No more |
Due to dotnet/roslyn#2444, we have disabled ECMA signing when the host platform for our build is not Windows. This is done by explicitly setting the property in our top level dir.props. Some of the reference assemblies explicitly set UseECMAKey to true, overwriting this value which leads to build breaks when building on non Windows platforms. Guard the setting of this property so that we don't override it if it already set. Fixes #3739
Get 8 errors when building latest corefx on ubuntu with dnx-coreclr-linux-x64.1.0.0-rc1-15838.
The text was updated successfully, but these errors were encountered: