This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Amend ServiceController dependency tests #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies the System.ServiceProcess.ServiceController dependency tests to verify the exact number of expected dependent/dependency services for each test service as well as the expected names for each dependent/ dependency. Also covers cases in which ServiceController.ServicesDependedOn has a length > 1. Fixes #653
|
@weshaggard, FYI commenting out the |
| { | ||
| _testService.DeleteTestServices(); | ||
| foreach (ServiceController service in services) |
There was a problem hiding this comment.
Code like this could be simplified with LINQ.
There was a problem hiding this comment.
Here I avoided taking the dependency on an additional NuGet package just for the sake of using IEnumerable.Where() once. If there were more code where LINQ applied, I would take the dependency.
|
LGTM. |
nslottow
added a commit
that referenced
this pull request
Feb 25, 2015
Amend ServiceController dependency tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the System.ServiceProcess.ServiceController dependency tests
to verify the exact number of expected dependent/dependency services
for each test service as well as the expected names for each dependent/
dependency.
Also covers cases in which ServiceController.ServicesDependedOn has
a length > 1.
Fixes #653