This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix the flags passed to getnameinfo #10392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were trying to pass NI_NAMEREQD to getnameinfo so that it would fail if the address could not be resolved. However, the PAL->Native translation was backward, resulting in the wrong flags getting passed.
ericeil
force-pushed
the
10345
branch
2 times, most recently
from
5460f99
to
593c745
Compare
|
LGTM. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were trying to pass
NI_NAMEREQDto getnameinfo so that it would fail if the address could not be resolved. However, the PAL->Native translation was backward, resulting in the wrong flags getting passed.Fixes #10345.
@stephentoub @CIPop