This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix RegistryKey.GetValue tests #1278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original tests rely on assumption that default value is not set for HKEY_CURRENT_USER. This assumption is wrong because default value of HKEY_CURRENT_USER could be used by someone else. Also original tests rely on assumption that value with name "tt" doesn't exists in HKEY_CURRENT_USER which also could be wrong on some machines. In general tests should be run against test subkey instead of HKEY_CURRENT_USER. This commit fixes this. Fixes #566
|
/cc @pallavit |
|
@Maxwe11 - Let me know if you are still working on this else I will pick this item next :) and unblock your other contribution :). |
|
@pallavit you are welcome because I'm stuck with how to properly handle result of RegQueryValueEx :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original tests rely on assumption that default value is not set for HKEY_CURRENT_USER. This assumption is wrong because default value of HKEY_CURRENT_USER could be used by someone else.
Also original tests rely on assumption that value with name "tt" doesn't exists in HKEY_CURRENT_USER which also could be wrong on some machines.
In general tests should be run against test subkey instead of HKEY_CURRENT_USER. This commit fixes this.
Fixes #566