This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Add ubuntu.XX-arm to runtime.native.XX.pkgproj #14655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds ubuntu.14.04-arm and ubuntu.16.04-arm into runtime.native.XX.pkgproj Signed-off-by: chunseoklee <chunseok.lee@samsung.com>
|
subtask for https://github.com/dotnet/core-setup/issues/725 |
|
LGTM |
qmfrederik
reviewed
Dec 21, 2016
| <ProjectReference Include="ubuntu\16.04\runtime.native.System.Security.Cryptography.OpenSsl.pkgproj"> | ||
| <Platform>amd64</Platform> | ||
| </ProjectReference> | ||
| <ProjectReference Include="ubuntu\16.04\runtime.native.System.Security.Cryptography.OpenSsl.pkgproj"> | ||
| <Platform>armx</Platform> |
There was a problem hiding this comment.
Did you mean for this to be arm instead of armx?
There was a problem hiding this comment.
@qmfrederik Nice catch! Thank you very much. @chunseoklee is on vacation, so I revised it and made another PR(#14677).
karelz
added
area-Infrastructure-libraries
arch-arm32
os-linux
|
Any reason Ubuntu 16.10 isn't also included? |
|
@mellinoe We don't have plans to support Ubuntu 16.10 ARM yet. I think it would be better to go into one PR later to support Ubuntu 16.10. |
|
closed since PR 14677 landed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds ubuntu.14.04-arm and ubuntu.16.04-arm into
runtime.native.XX.pkgproj
Signed-off-by: chunseoklee chunseok.lee@samsung.com