This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Updating CoreFx dependencies to servicing-24918-02 #15272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-bot
pushed a commit
that referenced
this pull request
Jan 13, 2018
One of the biggest costs when invoking Int32.ToString() and similar methods is in fetching the current culture, accessing its number information, etc. And if a culture is provided explicitly, there are still costs related to casts. But when the default format is used for non-negative integer values, the number format information isn't used at all, and we can skip the associated costs. This improves formatting perf in such cases by upwards of ~25%. Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
dotnet-bot
pushed a commit
that referenced
this pull request
Jan 13, 2018
One of the biggest costs when invoking Int32.ToString() and similar methods is in fetching the current culture, accessing its number information, etc. And if a culture is provided explicitly, there are still costs related to casts. But when the default format is used for non-negative integer values, the number format information isn't used at all, and we can skip the associated costs. This improves formatting perf in such cases by upwards of ~25%. Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
safern
pushed a commit
that referenced
this pull request
Jan 16, 2018
One of the biggest costs when invoking Int32.ToString() and similar methods is in fetching the current culture, accessing its number information, etc. And if a culture is provided explicitly, there are still costs related to casts. But when the default format is used for non-negative integer values, the number format information isn't used at all, and we can skip the associated costs. This improves formatting perf in such cases by upwards of ~25%. Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
safern
pushed a commit
that referenced
this pull request
Jan 16, 2018
One of the biggest costs when invoking Int32.ToString() and similar methods is in fetching the current culture, accessing its number information, etc. And if a culture is provided explicitly, there are still costs related to casts. But when the default format is used for non-negative integer values, the number format information isn't used at all, and we can skip the associated costs. This improves formatting perf in such cases by upwards of ~25%. Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.