Netstandard closure in NETCoreApp #15313
Conversation
For every assembly that is forwarded to by netstandard.dll, ensure it is a reference as part of NETCore.App
|
@dotnet-bot test Innerloop Windows_NT Debug Build and Test |
| @@ -3,5 +3,7 @@ | |||
| <Import Project="..\dir.props" /> | |||
| <PropertyGroup> | |||
| <AssemblyVersion>4.0.2.0</AssemblyVersion> | |||
| <IsNETCoreApp>true</IsNETCoreApp> | |||
There was a problem hiding this comment.
This one looks suspect. We should understand what is pulling it in.
There was a problem hiding this comment.
It's an implementation dependency of IsolatedStorage:
@JeremyKuhne added the dependency here: 86f5542
There was a problem hiding this comment.
@JeremyKuhne do we need this dependency? It will require us to pull in ACL's and its closure into the shared framework.
There was a problem hiding this comment.
I'm filing an issue for this and moving on.
There was a problem hiding this comment.
@weshaggard We need the functionality for sure. We could copy the code I suppose but I'm a little worried about missing fixes given this is code we haven't really extensively utilized.
There was a problem hiding this comment.
No need to copy it, just move it to common. Let's move the discussion over to #15337
@weshaggard NETStandard.Library is the source of that info, NETCore.App just makes sure it has everything NETStandard.Library has. This change was just trying to anticipate what you were going to add. |
…re-NETCoreApp Netstandard closure in NETCoreApp Commit migrated from dotnet/corefx@b92863a
Fixes #15083.
This adds a number of assemblies to netcoreapp.
The process I used to do this was look at our current NETCoreApp netstandard.dll ref and add all of its dependencies as both ref & lib, since we must support neststandard.dll. I then re-enabled closure validation for netstandard, then I added all other libs needed to make it closure complete.
@weshaggard please review. If you see anything here that shouldn't be it probably means we need to push types down.