Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Expose deconstruct api and add tests #17656

Merged
merged 1 commit into from
Mar 29, 2017
Merged

Conversation

safern
Copy link
Member

@safern safern commented Mar 29, 2017

This is a pick up of the abandoned PR: #14621

The implementation went into corert and coreclr but the APIs where never exposed in the contract nor tests where added.
Fixes: #13746

cc: @ianhays @stephentoub @danmosemsft

@safern safern added this to the 2.0.0 milestone Mar 29, 2017
@safern safern self-assigned this Mar 29, 2017
Copy link
Contributor

@ianhays ianhays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for picking this up @safern!

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks.

@safern
Copy link
Member Author

safern commented Mar 29, 2017

@dotnet-bot test Innerloop Windows_NT Debug x86 Build and Test please.

A System.IO.Test failed with the following error:

System.IO.IOException : The process cannot access the file 'C:\\Users\\dotnet-bot\\AppData\\Local\\Temp\\FileInfo_Open_fm_fa_fs_y2jmn1nt.sx1\\FileShareOpen_43' because it is being used by another process.

cc: @JeremyKuhne More details here

@stephentoub stephentoub merged commit 376a334 into dotnet:master Mar 29, 2017
@safern safern deleted the Deconstruct branch March 29, 2017 18:35
@safern
Copy link
Member Author

safern commented Mar 29, 2017

Thanks for reviewing!

@jcouv
Copy link
Member

jcouv commented Apr 8, 2017

Looks good.
Will this also be implemented in .NET Framework and Mono? (ping @marek-safar for the latter)
Do we have a process to tag PRs that will need porting?

@safern
Copy link
Member Author

safern commented Apr 8, 2017

We add the netfx-port-consider to track issues that need porting to full framework, but we do that on the issue itself not on the PR.

The issue is already labeled to port it.

@marek-safar
Copy link
Contributor

@jcouv Mono is tracking the new api and they will be included in upcoming releases

@vanillajonathan
Copy link
Contributor

Is this method documented?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
7 participants