This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Adding System.Drawing.Common.Drawing2D GraphicsPathIterator tests. #20711 #22157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. Test CopyData_StartEndIndexesOutOfRange_ReturnsExpeced() fails with exception System.EntryPointNotFoundException : Unable to find an entry point named 'ZeroMemory' in DLL 'kernel32.dll' , issue is tracked in (#22026). (#20711)
mellinoe
reviewed
Jul 12, 2017
|
|
||
| //[ConditionalTheory(nameof(PlatformDetection) + "." + nameof(PlatformDetection.IsNotWindowsNanoServer))] | ||
| //[MemberData(nameof(CopyData_StartEndIndexesOutOfRange_TestData))] | ||
| //public void CopyData_StartEndIndexesOutOfRange_ReturnsExpeced(PointF[] points, byte[] types, int startIndex, int endIndex) |
There was a problem hiding this comment.
Can you uncomment this, and instead add an [ActiveIssue(22026)] attribute? This will prevent it from running, but will still compile the code.
|
LGTM, just left one comment. Thanks for the continued help! |
…fRange_ReturnsExpeced()
|
Looks good, I'll merge this when the CI is green. Thanks again! |
pjanotti
pushed a commit
to pjanotti/corefx
that referenced
this pull request
Jul 20, 2017
…0711 (dotnet#22157) * Adding System.Drawing.Common.Drawing2D GraphicsPathIteratorTests tests. Test CopyData_StartEndIndexesOutOfRange_ReturnsExpeced() fails with exception System.EntryPointNotFoundException : Unable to find an entry point named 'ZeroMemory' in DLL 'kernel32.dll' , issue is tracked in (#22026). (#20711) * Adding [ActiveIssue(22026)] attribute to CopyData_StartEndIndexesOutOfRange_ReturnsExpeced()
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…tnet/corefx#20711 (dotnet/corefx#22157) * Adding System.Drawing.Common.Drawing2D GraphicsPathIteratorTests tests. Test CopyData_StartEndIndexesOutOfRange_ReturnsExpeced() fails with exception System.EntryPointNotFoundException : Unable to find an entry point named 'ZeroMemory' in DLL 'kernel32.dll' , issue is tracked in (dotnet/corefx#22026). (dotnet/corefx#20711) * Adding [ActiveIssue(22026)] attribute to CopyData_StartEndIndexesOutOfRange_ReturnsExpeced() Commit migrated from dotnet/corefx@d57ac4d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting mono GraphicsPathIterator tests and adding few new.
Test CopyData_StartEndIndexesOutOfRange_ReturnsExpeced() fails with exception System.EntryPointNotFoundException : Unable to find an entry point named 'ZeroMemory' in DLL 'kernel32.dll' , issue is tracked in (#22026). (#20711)