This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Adding System.Drawing.Common.Drawing2D PathGradientBrush tests. #20711 #22199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! |
|
I will add test for Disposed. |
mellinoe
suggested changes
Jul 13, 2017
| private readonly RectangleF _defaultRectangle = new RectangleF(1, 2, 19, 28); | ||
|
|
||
| [ConditionalFact(nameof(PlatformDetection) + "." + nameof(PlatformDetection.IsNotWindowsNanoServer))] | ||
| public void Ctor_Points_ReturmsExpected() |
|
|
||
| [ConditionalTheory(nameof(PlatformDetection) + "." + nameof(PlatformDetection.IsNotWindowsNanoServer))] | ||
| [MemberData(nameof(WrapMode_TestData))] | ||
| public void Ctor_PointsWrapMode_ReturmsExpected(WrapMode wrapMode) |
| [ConditionalTheory(nameof(PlatformDetection) + "." + nameof(PlatformDetection.IsNotWindowsNanoServer))] | ||
| [InlineData(0)] | ||
| [InlineData(1)] | ||
| public void Ctor_PointsLenghtLessThenTwo_ThrowsOutOfMemoryException(int pointsLeght) |
There was a problem hiding this comment.
Also pointsLeght pointsLength
| { | ||
| using (PathGradientBrush brush = new PathGradientBrush(_defaultFloatPoints)) | ||
| { | ||
| AssertExtensions.Throws<ArgumentNullException>("source",() => brush.Blend = new Blend() { Factors = new float[0], Positions = null }); |
There was a problem hiding this comment.
nit: space after "source",
| { | ||
| using (PathGradientBrush brush = new PathGradientBrush(_defaultFloatPoints)) | ||
| { | ||
| Assert.Throws<NullReferenceException>(() => brush.InterpolationColors = new ColorBlend() { Colors = null, Positions = null }); |
There was a problem hiding this comment.
nit: Some of these lines are a bit long. Can you put some of these onto multiple lines, if they are over ~120 characters?
There was a problem hiding this comment.
It's mainly the calls to Assert.Throws that get pretty long here.
mellinoe
reviewed
Jul 14, 2017
| @@ -82,7 +82,7 @@ public void Ctor_PointsNull_ThrowsArgumentNullException() | |||
| [ConditionalTheory(nameof(PlatformDetection) + "." + nameof(PlatformDetection.IsNotWindowsNanoServer))] | |||
| [InlineData(0)] | |||
| [InlineData(1)] | |||
| public void Ctor_PointsLenghtLessThenTwo_ThrowsOutOfMemoryException(int pointsLeght) | |||
| public void Ctor_PointsLengthLessThenTwo_ThrowsOutOfMemoryException(int pointsLeght) | |||
There was a problem hiding this comment.
The parameter here is still misspelled: "pointsLeght".
mellinoe
reviewed
Jul 14, 2017
| @@ -82,12 +82,12 @@ public void Ctor_PointsNull_ThrowsArgumentNullException() | |||
| [ConditionalTheory(nameof(PlatformDetection) + "." + nameof(PlatformDetection.IsNotWindowsNanoServer))] | |||
| [InlineData(0)] | |||
| [InlineData(1)] | |||
| public void Ctor_PointsLengthLessThenTwo_ThrowsOutOfMemoryException(int pointsLeght) | |||
| public void Ctor_PointsLengthLessThenTwo_ThrowsOutOfMemoryException(int pointsLegth) | |||
There was a problem hiding this comment.
Not trying to be picky... but it's still misspelled 😄
There was a problem hiding this comment.
ha ha omg :))) I am fixing it
|
LGTM. Thanks! |
pjanotti
pushed a commit
to pjanotti/corefx
that referenced
this pull request
Jul 20, 2017
dotnet#22199) * Adding System.Drawing.Common.Drawing2D PathGradientBrush tests. #20711 * Adding test for Dispose(). * Fixing some spellings and splinting long statement to multiple lines. * Completing tests for Disposed. * Spelling correction. * Spelling correction.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…t/corefx#20711 (dotnet/corefx#22199) * Adding System.Drawing.Common.Drawing2D PathGradientBrush tests. dotnet/corefx#20711 * Adding test for Dispose(). * Fixing some spellings and splinting long statement to multiple lines. * Completing tests for Disposed. * Spelling correction. * Spelling correction. Commit migrated from dotnet/corefx@04598fd
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting mono PathGradientBrush tests and adding few new. #20711