This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
release/2.0: Use a shared MultiAgent in CurlHandler when using LibreSSL backend on macOS #22243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… macOS LibreSSL needs locks initialized in order to be used safely from multiple threads, which happens when multiple HttpClients are used. But we don't currently have a good way to perform that initialization as we do for OpenSSL. As a workaround, add a shared MultiAgent that's initialized when LibreSSL is used on macOS, and use that same MultiAgent from all CurlHandler instances rather than giving each their own. Since MultiAgent is 1:1 with a thread, all HttpClient's will then end up sharing the same libcurl event loop thread, and we'll serialize all of our interactions with libcurl and thus hopefully with LibreSSL.
bartonjs
approved these changes
Jul 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LibreSSL needs locks initialized in order to be used safely from
multiple threads, which happens when multiple HttpClients are used. But
we don't currently have a good way to perform that initialization as we
do for OpenSSL. As a workaround, add a shared MultiAgent that's
initialized when LibreSSL is used on macOS, and use that same MultiAgent
from all CurlHandler instances rather than giving each their own. Since
MultiAgent is 1:1 with a thread, all HttpClient's will then end up
sharing the same libcurl event loop thread, and we'll serialize all of
our interactions with libcurl and thus hopefully with LibreSSL.
cc: @bartonjs, @geoffkizer, @nguerrera, @Petermarcu