This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Adding System.Drawing.Common.Imaging Metafile tests. (#20711) #22753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PlatformDetection.IsNotWindowsNanoServer))] to [ConditionalTheory(Helpers.GdiplusIsAvailable)]
…nalFact(Helpers.IsNotLinuxAndGdiplusIsAvailable)]
mellinoe
suggested changes
Jul 31, 2017
| @@ -12,6 +12,7 @@ namespace System.Drawing | |||
| public static class Helpers | |||
| { | |||
| public const string GdiplusIsAvailable = nameof(Helpers) + "." + nameof(GetGdiplusIsAvailable); | |||
| public const string IsNotLinuxAndGdiplusIsAvailable = nameof(Helpers) + "." + nameof(CheckIsNotLinuxAndGdiplusIsAvailable); | |||
There was a problem hiding this comment.
Instead of adding this, you should just annotate the failing tests with [ActiveIssue(20884, TestPlatforms.AnyUnix)] like the others.
mellinoe
approved these changes
Jul 31, 2017
|
Thanks @KostaVlev |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…0711) (dotnet/corefx#22753) * Adding System.Drawing.Common.Imaging Metafile tests. (dotnet/corefx#20711) * Changing [ConditionalTheory(nameof(PlatformDetection) + "." + nameof(PlatformDetection.IsNotWindowsNanoServer))] to [ConditionalTheory(Helpers.GdiplusIsAvailable)] * Changing [ConditionalTheory(Helpers.GdiplusIsAvailable)] to [ConditionalFact(Helpers.IsNotLinuxAndGdiplusIsAvailable)] * Changing the way tests will skip Unix. Commit migrated from dotnet/corefx@9b13e7f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding System.Drawing.Common.Imaging.Metafile tests. (#20711)