This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Porting a fix for #21689 to release/2.0.0 #23512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otnet#22117) Such types are still generic but don't have a tick in their name, which the name lookup expects all generic types' names to have. Handle this case correctly. Fixes #21689
|
@JonHanna @OmarTawfik @jaredpar - please review. |
|
This is a cherry-picked fix for https://github.com/dotnet/corefx/issues/21689 from master to release/2.0.0 |
JonHanna
approved these changes
Aug 23, 2017
OmarTawfik
approved these changes
Aug 24, 2017
|
@VSadov please don't forget to get servicing approval from .NET Core shiproom alias. |
|
@karelz - Re: shiproom. Did that, but it seems we could be late to the train for the 0.1 servicing release. Will try get this into 0.2 |
danmoseley
added
the
* NO MERGE *
|
I'm going to mark no merge until 0.1 has left the station. |
|
What's the ETA for 2.0.2? |
|
@bruno-garcia I don't think there is public ETA - @leecow can you please comment? |
|
October is the next possibility. |
|
We've been running just fine on 1.1. We can wait another month to migrate :) |
|
Another refcount on this. https://github.com/dotnet/corefx/issues/23855 |
Petermarcu
added
Servicing-Approved-2.0.2
and removed
* NO MERGE *
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
release/2.0.0 port of #22117 (Fix bug in MS.CSharp handling non-generic classes nested in generic)
Such types are still generic but don't have a tick in their name, which
the name lookup expects all generic types' names to have.
Handle this case correctly.
Fixes #21689