This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Don't use Array.Reverse in ImmutableArray<T>.Builder.Reverse #2354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The non-generic
Array.Reverse
does not perform well for non-primitive value types.See the following for details:
dotnet/coreclr#1231
Note: I considered adding a common
ArrayHelpers
class, as there are some other uses ofArray.Reverse
in corefx. However, the other uses didn't seem to warrant the use of the improvedReverse
:Array.Reverse
onbyte[]
which is a primitive type thatArray.Reverse
has a fast-path for (example, example, etc.).Stack<T>.CopyTo
callsArray.Reverse
only in a rare caseReadOnlyCollectionBuilder<T>
is internal and it doesn't look likeReadOnlyCollectionBuilder.Reverse
is actually used at all.