Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Updated the error message for missing dia sdk in build.cmd. Closes #2… #25859

Merged
merged 2 commits into from
Dec 13, 2017

Conversation

OzieGamma
Copy link
Contributor

…5856

@OzieGamma
Copy link
Contributor Author

First PR failed to trigger bots/tests. #25858

@danmoseley
Copy link
Member

Thanks @OzieGamma if you put Fixes #25858 in the topmost comment then when this is merge it will autoresolve.

We still support VS2015 according to that link -- didn't it have the DIA install bug? @weshaggard

@OzieGamma
Copy link
Contributor Author

I installed VS2015 and the installer correctly installed the DIA SDK.

@danmoseley
Copy link
Member

Sounds good to me but I don't know the history of this error @weshaggard OK w/ you?

@weshaggard
Copy link
Member

Based on dotnet/coreclr#14948, I think the issue is that this isn't always available with VS2017 not VS2015. That said I'm not even sure if it is needed for corefx I think this might be left over from a copy in coreclr.

@danmoseley
Copy link
Member

@mikem8361 have you any context on when the issue referenced in this error was fixed?

@OzieGamma
Copy link
Contributor Author

The original message mentions coreclr as a fix (I changed it to the corefx documentation). Does the check need to be completely removed?

Changing the VS 2017 install does install the DIA SDK. I was missing it. So the check did catch that error. The error message just sent me down the wrong solution.

@mikem8361
Copy link
Member

mikem8361 commented Dec 13, 2017 via email

@danmoseley danmoseley merged commit 7dd8fa0 into dotnet:master Dec 13, 2017
@danmoseley
Copy link
Member

OK we thought about this enough. merged. thanks for the change @OzieGamma

@OzieGamma OzieGamma deleted the update-error-message-dia-sdk branch December 13, 2017 22:08
@karelz karelz added this to the 2.1.0 milestone Dec 28, 2017
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants